From 9c615fb06bef72b17de2f11170f41f3309ff5988 Mon Sep 17 00:00:00 2001 From: Ayesh Karunaratne Date: Thu, 19 Feb 2026 14:21:58 +0530 Subject: [PATCH 1/2] NEWS: fix minor formatting [skip-ci] --- NEWS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 3c6f5e959d01..4b2fa4b0adf8 100644 --- a/NEWS +++ b/NEWS @@ -41,7 +41,7 @@ PHP NEWS . Fixed bug GH-21227 (Borked SCCP of array containing partial object). (ilutov) - OpenSSL: +- OpenSSL: . Fix a bunch of leaks and error propagation. (ndossche) - Windows: From 636fd3453b795ac7c207728da8c5c58286c0099a Mon Sep 17 00:00:00 2001 From: Ilija Tovilo Date: Thu, 19 Feb 2026 11:38:20 +0100 Subject: [PATCH 2/2] Fix nightly ref name git rev-parse fails with the long GH ref, but we need github.ref to check out branches from PRs. Hence, use github.ref only for PRs, and the ref_name for everything else. Closes GH-21255 --- .github/matrix.php | 18 +++++++++--------- .github/workflows/test.yml | 2 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/.github/matrix.php b/.github/matrix.php index 161c2241a963..829ddfe884f5 100644 --- a/.github/matrix.php +++ b/.github/matrix.php @@ -1,11 +1,11 @@ 'master', 'ref' => 'refs/heads/master', 'version' => [8, 6]], - ['name' => 'PHP-8.5', 'ref' => 'refs/heads/PHP-8.5', 'version' => [8, 5]], - ['name' => 'PHP-8.4', 'ref' => 'refs/heads/PHP-8.4', 'version' => [8, 4]], - ['name' => 'PHP-8.3', 'ref' => 'refs/heads/PHP-8.3', 'version' => [8, 3]], - ['name' => 'PHP-8.2', 'ref' => 'refs/heads/PHP-8.2', 'version' => [8, 2]], + ['name' => 'master', 'ref' => 'master', 'version' => [8, 6]], + ['name' => 'PHP-8.5', 'ref' => 'PHP-8.5', 'version' => [8, 5]], + ['name' => 'PHP-8.4', 'ref' => 'PHP-8.4', 'version' => [8, 4]], + ['name' => 'PHP-8.3', 'ref' => 'PHP-8.3', 'version' => [8, 3]], + ['name' => 'PHP-8.2', 'ref' => 'PHP-8.2', 'version' => [8, 2]], ]; function get_branch_commit_cache_file_path(): string { @@ -81,7 +81,7 @@ function select_jobs($repository, $trigger, $nightly, $labels, $php_version, $re : ['type' => ['asan']]; $jobs['COMMUNITY']['config']['symfony_version'] = version_compare($php_version, '8.4', '>=') ? '8.1' : '7.4'; } - if (($all_jobs && $ref === 'refs/heads/master') || $test_coverage) { + if (($all_jobs && $ref === 'master') || $test_coverage) { $jobs['COVERAGE'] = true; } if ($all_jobs || $test_libmysqlclient) { @@ -129,7 +129,7 @@ function select_jobs($repository, $trigger, $nightly, $labels, $php_version, $re if ($all_jobs || $test_opcache_variation) { $jobs['OPCACHE_VARIATION'] = true; } - if (($all_jobs && $ref === 'refs/heads/master') || $test_pecl) { + if (($all_jobs && $ref === 'master') || $test_pecl) { $jobs['PECL'] = true; } if ($all_jobs || !$no_jobs || $test_windows) { @@ -160,9 +160,9 @@ function select_jobs($repository, $trigger, $nightly, $labels, $php_version, $re if ($discard_cache) { @unlink(get_branch_commit_cache_file_path()); } -$branch = $argv[3] ?? 'refs/heads/master'; +$branch = $argv[3] ?? 'master'; $nightly = $trigger === 'schedule' || $trigger === 'workflow_dispatch'; -$branches = $nightly && $branch === 'refs/heads/master' +$branches = $nightly && $branch === 'master' ? get_branches() : [['name' => 'Suite', 'ref' => $branch, 'version' => get_current_version()]]; diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 0b2882b6abc5..0970975df194 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -59,7 +59,7 @@ jobs: nightly- - name: Generate Matrix id: set-matrix - run: php .github/matrix.php "${{ github.event_name }}" "${{ github.run_attempt }}" "${{ github.ref }}" '${{ toJSON(github.event.pull_request.labels) }}' "${{ github.repository }}" + run: php .github/matrix.php "${{ github.event_name }}" "${{ github.run_attempt }}" "${{ github.event_name == 'pull_request' && github.ref || github.ref_name }}" '${{ toJSON(github.event.pull_request.labels) }}' "${{ github.repository }}" TEST: needs: GENERATE_MATRIX name: ${{ matrix.branch.name }}