Safari breaks with TypeError when authenticatorAttachment is null

[tomsommer]

When setting AUTHENTICATOR_ATTACHMENT_NO_PREFERENCE authenticatorAttachment becomes null in the serialized output. Safari breaks with a TypeError if this happens. authenticatorAttachment should instead be removed from the output, null is not a valid value, according to Safari.

[Spomky]

Hi @tomsommer,

Do you use the Symfony Bundle with custom option handlers or the library?
Normally, null values are not in the serialized options. See DefaultCreationOptionsHandler.php#L29 or DefaultRequestOptionsHandler.php#L29

[tomsommer]

I don't use any bundle, I just do
(new WebauthnSerializerFactory(AttestationStatementSupportManager::create()))->create()->serialize(.... ,'json')

[Spomky]

OK, then can you try using the context options:

use Symfony\Component\Serializer\Normalizer\AbstractObjectNormalizer;

(new WebauthnSerializerFactory(AttestationStatementSupportManager::create()))->create()->serialize(.... ,'json', [AbstractObjectNormalizer::SKIP_NULL_VALUES => true])

[tomsommer]

This solves it. I would suggest this be the default then, since it will not produce valid output otherwise :)

Or at least note it somewhere in the docs, so other people won't hit the same issue.

[Spomky]

👍Perfect. Many thanks for the confirmation.
This context argument is used in the documentation, but not highlighted as it should be.
I move this issue to the doc repository and will update some pages.