`webui_wait()` doesn’t return after closing WebView on Linux (since 760211a)

[triuk]

See comment with full details: 760211a#commitcomment-175654426
The issue comes with 760211a.

[AlbertShown]

Thank you @triuk for reporting this, I'm working on it.

[AlbertShown]

Adding wait_async() was more complex than I taught...

[AlbertShown]

An experimental fix is done here 0e81fef

[triuk]

It ends now, but not in a healthy way.
Console WebViewGTK:

[User] webui_is_shown([1])
[User] webui_is_shown([1])
[Core]          _webui_wv_free()
[Core]          _webui_wv_free() -> Unload WebKit
[Core]          _webui_wv_free() -> Unload GTK
fish: Job 1, '/path/to/binary…' terminated by signal SIGSEGV (Address boundary error)

In constrast, this is how Chromium ends:

[User] webui_is_shown([1])
[Core]          _webui_server_thread([1]) -> Cleaning
[Core]          _webui_free_port([59422])
[Core]          _webui_free_mem(0x0x7fe99c000be0)
[Core]          _webui_free_mem(0x0x7fe99c000be0) -> Pointer #15 freed (64 + 1 bytes)
[Core]          _webui_server_thread([1]) -> Server stopped.
[Core]          _webui_make_window_reusable(1)
[Core]          _webui_server_thread([1]) -> Breaking main loop...
[Core]          _webui_condition_signal()
[Loop] _webui_wait_clean(Blocking) -> Cleaning...
[User] webui_is_shown([1])
[User] webui_is_shown([1])
[User] webui_is_shown([1])
[User] webui_is_shown([1])
[User] webui_is_shown([1])
[User] webui_is_shown([1])
[User] webui_is_shown([1])
[User] webui_is_shown([1])
[User] webui_is_shown([1])
[Loop] _webui_wait_clean() -> Main loop exit successfully

And the Windows 10 WebView2 has some problems at runtime too - it just closes itself after like 10 seconds leaving window open, but maybe not related to this issue.

[AlbertShown]

All those issues are because of the core modification done to add wait_async(), however, I found the root issue, and all of them are almost all fixed. I will push a PR soon.

[AlbertShown]

Experimental 2 - Fix webui_wait (sync and async)

[AlbertShown]

Fixed in 1cfad3c

[triuk]

@AlbertShown Hi, I ran the newest version, but I still get SIGSEGV at the end for Linux GTK (will try on Windows later):

[Core]          _webui_free_mem(0x0x7f2fb40054a0)
[Core]          _webui_free_mem(0x0x7f2fb40054a0) -> Pointer #14 freed (56 + 1 bytes)
[Loop] _webui_wait(Blocking)
[Loop] _webui_wait() -> Waiting (Timeout in 15 seconds)
[Loop] _webui_wait() -> Linux WebView loop
[Core]          _webui_wv_event_on_close()
[Core]          _webui_wv_event_closed()
[Core]          _webui_ws_data_handler()
[Core]          _webui_ws_close_handler()
[Core]          _webui_get_ws_process_number()
[Core] [WS #2]  _webui_receive([1], [3], [0])
[Core]          _webui_connection_get_id([1], [0x7f2fa002d9d0])
[Core]          _webui_connection_remove([1])
[Core]          _webui_connection_remove() -> Removing client #0 
[Core] [WS #2]  _webui_receive(1) -> Connection #0 Closed
[Core]          _webui_malloc([56])
[Core]          _webui_ptr_add(0x0x7f2fb40054a0)
[Core]          _webui_ptr_exist()
[Core]          _webui_ptr_add(0x0x7f2fb40054a0) -> Pointer #13 saved (56 + 1 bytes)
[Core]          [Thread .] _webui_ws_process_thread()
[Core] [WS #2]  _webui_ws_process()
[Core] [WS #2]  _webui_ws_process() -> Start
[Core] [WS #2]  _webui_ws_process() -> WEBUI_WS_CLOSE 
[Core]          _webui_make_window_reusable(1)
[Core] [WS #2]  _webui_ws_process() -> Finished.
[Core]          _webui_free_mem(0x(nil))
[Core]          _webui_free_mem(0x0x7f2fb40054a0)
[Core]          _webui_free_mem(0x0x7f2fb40054a0) -> Pointer #13 freed (56 + 1 bytes)
[Core]          _webui_server_thread([1]) -> Window disconnected
[Core]          _webui_server_thread([1]) -> Server stopping...
[Core]          _webui_webview_update(1)
[Core]          _webui_condition_signal()
[Core]          [Thread .] _webui_webview_thread() -> Cleaning
[Core]          _webui_wv_close()
[Core]          _webui_free_mem(0x0x555c99c6f100)
[Core]          _webui_free_mem(0x0x555c99c6f100) -> Pointer #10 freed (22 + 1 bytes)
[Core]          _webui_free_mem(0x0x555c99b7c270)
[Core]          _webui_free_mem(0x0x555c99b7c270) -> Pointer #11 freed (56 + 1 bytes)
[Core]          [Thread .] _webui_webview_thread() -> End
[Core]          _webui_free_port([32976])
[Core]          _webui_free_mem(0x0x7f2fa0003d30)
[Core]          _webui_free_mem(0x0x7f2fa0003d30) -> Pointer #9 freed (64 + 1 bytes)
[Core]          _webui_server_thread([1]) -> Server stopped.
[Core]          _webui_make_window_reusable(1)
[Core]          _webui_server_thread([1]) -> Breaking main loop...
[Core]          _webui_condition_signal()
[Core]          _webui_wv_exit_schedule() -> Quit GTK Main Loop...
[Loop] _webui_wait_clean(Blocking) -> Cleaning...
[Core]          _webui_wv_free()
[Core]          _webui_wv_free() -> Unload WebKit
[Core]          _webui_wv_free() -> Unload GTK
Neoprávněný přístup do paměti (SIGSEGV)                  (core dumped [obraz paměti uložen]) /home/gordon/Dokumenty/PlatformIO/Projects/webui/build/main.out

[AlbertShown]

I can't reproduce the issue, I run the minimal example and it exit successfully (Ubuntu, WebView).

[Core]          _webui_free_mem(0x0x7efe7c004ba0)
[Core]          _webui_free_mem(0x0x7efe7c004ba0) -> Pointer #14 freed (56 + 1 bytes)
[Loop] _webui_wait(Blocking)
[Loop] _webui_wait() -> Waiting (Timeout in 15 seconds)
[Loop] _webui_wait() -> Linux WebView loop
[Core]          _webui_wv_event_on_close()
[Core]          _webui_wv_event_closed()
[Core]          _webui_ws_data_handler()
[Core]          _webui_ws_close_handler()
[Core]          _webui_get_ws_process_number()
[Core] [WS #2]  _webui_receive([1], [3], [0])
[Core]          _webui_connection_get_id([1], [0x7efe5802a630])
[Core]          _webui_connection_remove([1])
[Core]          _webui_connection_remove() -> Removing client #0
[Core] [WS #2]  _webui_receive(1) -> Connection #0 Closed
[Core]          _webui_malloc([56])
[Core]          _webui_ptr_add(0x0x7efe7c004ba0)
[Core]          _webui_ptr_exist()
[Core]          _webui_ptr_add(0x0x7efe7c004ba0) -> Pointer #13 saved (56 + 1 bytes)
[Core]          [Thread .] _webui_ws_process_thread()
[Core] [WS #2]  _webui_ws_process()
[Core] [WS #2]  _webui_ws_process() -> Start
[Core] [WS #2]  _webui_ws_process() -> WEBUI_WS_CLOSE
[Core]          _webui_make_window_reusable(1)
[Core] [WS #2]  _webui_ws_process() -> Finished.
[Core]          _webui_free_mem(0x(nil))
[Core]          _webui_free_mem(0x0x7efe7c004ba0)
[Core]          _webui_free_mem(0x0x7efe7c004ba0) -> Pointer #13 freed (56 + 1 bytes)
[Core]          _webui_server_thread([1]) -> Window disconnected
[Core]          _webui_server_thread([1]) -> Server stopping...
[Core]          _webui_webview_update(1)
[Core]          _webui_condition_signal()
[Core]          [Thread .] _webui_webview_thread() -> Cleaning
[Core]          _webui_wv_close()
[Core]          _webui_free_mem(0x0x5834ca484080)
[Core]          _webui_free_mem(0x0x5834ca484080) -> Pointer #10 freed (22 + 1 bytes)
[Core]          _webui_free_mem(0x0x5834ca47fbc0)
[Core]          _webui_free_mem(0x0x5834ca47fbc0) -> Pointer #11 freed (56 + 1 bytes)
[Core]          [Thread .] _webui_webview_thread() -> End
[Core]          _webui_free_port([45678])
[Core]          _webui_free_mem(0x0x7efe58000bc0)
[Core]          _webui_free_mem(0x0x7efe58000bc0) -> Pointer #9 freed (64 + 1 bytes)
[Core]          _webui_server_thread([1]) -> Server stopped.
[Core]          _webui_make_window_reusable(1)
[Core]          _webui_server_thread([1]) -> Breaking main loop...
[Core]          _webui_condition_signal()
[Core]          _webui_wv_exit_schedule() -> Quit GTK Main Loop...
[Loop] _webui_wait_clean(Blocking) -> Cleaning...
[Core]          _webui_wv_free()
[Core]          _webui_wv_free() -> Unload WebKit
[Core]          _webui_wv_free() -> Unload GTK
[Loop] _webui_wait_clean() -> Main loop exit successfully

[AlbertShown]

1. Is this the minimal example?
2. Can you give me a reproducible issue code?

[triuk]

1. Yes
2. Just the minimal example from webui

My setup

System:
- OS: EndeavourOS Linux (rolling)
- Kernel: 6.18.6-arch1-1 (x86_64)
- CPU: AMD PRO A8-8600B (4C/4T)

Session:
- Display server: Wayland (XDG_SESSION_TYPE=wayland)

Toolchain:
- GCC: 15.2.1 (g++ 15.2.1)
- CMake: 4.2.3
- Ninja: 1.13.2
- pkg-config: 2.5.1
- glibc: 2.42

GTK / GLib:
- GTK4: 4.20.3
- GTK3: 3.24.51
- GLib: 2.86.3
- GObject: 2.86.3

Steps to reproduce

1. Clone webui-dev/webui
2. Cmake: Configure
3. Build
4. Run ./build/minimal
5. Close window using (X)

Report

Build output:

[main] Building folder: /home/gordon/Dokumenty/PlatformIO/webui/build 
[build] Starting build
[proc] Executing command: /usr/bin/cmake --build /home/gordon/Dokumenty/PlatformIO/webui/build --config Debug --target all --
[build] [5/9  11% :: 0.483] Building C object CMakeFiles/call_js_from_c.dir/examples/C/call_js_from_c/main.c.o
[build] [5/9  22% :: 3.151] Building CXX object CMakeFiles/minimal.dir/examples/C++/minimal/main.cpp.o
[build] [5/9  33% :: 3.390] Building CXX object CMakeFiles/call_js_from_cpp.dir/examples/C++/call_js_from_cpp/main.cpp.o
[build] [5/9  44% :: 3.508] Building C object CMakeFiles/webui.dir/src/webui.c.o
[build] /home/gordon/Dokumenty/PlatformIO/webui/src/webui.c: In function ‘_webui_get_cookies_full’:
[build] /home/gordon/Dokumenty/PlatformIO/webui/src/webui.c:9579:41: warning: passing argument 2 of ‘_webui_is_mg_client_valid’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
[build]  9579 |     if(!_webui_is_mg_client_valid(NULL, client))
[build]       |                                         ^~~~~~
[build] /home/gordon/Dokumenty/PlatformIO/webui/src/webui.c:4846:83: note: expected ‘struct mg_connection *’ but argument is of type ‘const struct mg_connection *’
[build]  4846 | static bool _webui_is_mg_client_valid(_webui_window_t* win, struct mg_connection* client) {
[build]       |                                                             ~~~~~~~~~~~~~~~~~~~~~~^~~~~~
[build] /home/gordon/Dokumenty/PlatformIO/webui/src/webui.c: In function ‘_webui_get_cookies’:
[build] /home/gordon/Dokumenty/PlatformIO/webui/src/webui.c:9594:41: warning: passing argument 2 of ‘_webui_is_mg_client_valid’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
[build]  9594 |     if(!_webui_is_mg_client_valid(NULL, client))
[build]       |                                         ^~~~~~
[build] /home/gordon/Dokumenty/PlatformIO/webui/src/webui.c:4846:83: note: expected ‘struct mg_connection *’ but argument is of type ‘const struct mg_connection *’
[build]  4846 | static bool _webui_is_mg_client_valid(_webui_window_t* win, struct mg_connection* client) {
[build]       |                                                             ~~~~~~~~~~~~~~~~~~~~~~^~~~~~
[build] [5/9  55% :: 3.969] Building C object CMakeFiles/webui.dir/src/civetweb/civetweb.c.o
[build] [6/9  66% :: 4.095] Linking C static library libwebui-2-static.a
[build] [9/9  77% :: 4.208] Linking C executable call_js_from_c
[build] [9/9  88% :: 4.331] Linking CXX executable call_js_from_cpp
[build] [9/9 100% :: 4.371] Linking CXX executable minimal
[driver] Build completed: 00:00:04.451
[build] Build finished with exit code 0

Terminal during runtime:

...
[Core]          _webui_send_client_ws() -> 29 bytes sent.
[Core]          _webui_free_mem(0x0x7f418c000c00)
[Core]          _webui_free_mem(0x0x7f418c000c00) -> Pointer #16 freed (29 + 1 bytes)
[Core]          _webui_free_mem(0x0x7f418c000be0)
[Core]          _webui_free_mem(0x0x7f418c000be0) -> Pointer #15 freed (20 + 1 bytes)
[Core] [WS #1]  _webui_ws_process() -> Finished.
[Core]          _webui_free_mem(0x0x7f4198004f00)
[Core]          _webui_free_mem(0x0x7f4198004f00) -> Pointer #13 freed (9 + 1 bytes)
[Core]          _webui_free_mem(0x0x7f4198004c40)
[Core]          _webui_free_mem(0x0x7f4198004c40) -> Pointer #14 freed (56 + 1 bytes)
[Loop] _webui_wait(Blocking)
[Loop] _webui_wait() -> Waiting (Timeout in 15 seconds)
[Loop] _webui_wait() -> Linux WebView loop
[Core]          _webui_wv_event_on_close()
[Core]          _webui_wv_event_closed()
[Core]          _webui_ws_data_handler()
[Core]          _webui_ws_close_handler()
[Core]          _webui_get_ws_process_number()
[Core] [WS #2]  _webui_receive([1], [3], [0])
[Core]          _webui_connection_get_id([1], [0x7f419c02cca0])
[Core]          _webui_connection_remove([1])
[Core]          _webui_connection_remove() -> Removing client #0 
[Core]          _webui_server_thread([1]) -> Window disconnected
[Core]          _webui_server_thread([1]) -> Server stopping...
[Core]          _webui_webview_update(1)
[Core]          _webui_condition_signal()
[Core] [WS #2]  _webui_receive(1) -> Connection #0 Closed
[Core]          _webui_malloc([56])
[Core]          _webui_ptr_add(0x0x7f4198004c40)
[Core]          _webui_ptr_exist()
[Core]          _webui_ptr_add(0x0x7f4198004c40) -> Pointer #13 saved (56 + 1 bytes)
[Core]          [Thread .] _webui_ws_process_thread()
[Core] [WS #2]  _webui_ws_process()
[Core] [WS #2]  _webui_ws_process() -> Start
[Core] [WS #2]  _webui_ws_process() -> WEBUI_WS_CLOSE 
[Core]          _webui_make_window_reusable(1)
[Core] [WS #2]  _webui_ws_process() -> Finished.
[Core]          _webui_free_mem(0x(nil))
[Core]          [Thread .] _webui_webview_thread() -> Cleaning
[Core]          _webui_wv_close()
[Core]          _webui_free_mem(0x0x55675b9d1320)
[Core]          _webui_free_mem(0x0x55675b9d1320) -> Pointer #10 freed (22 + 1 bytes)
[Core]          _webui_free_mem(0x0x55675b99ec80)
[Core]          _webui_free_mem(0x0x55675b99ec80) -> Pointer #11 freed (56 + 1 bytes)
[Core]          [Thread .] _webui_webview_thread() -> End
[Core]          _webui_free_mem(0x0x7f4198004c40)
[Core]          _webui_free_mem(0x0x7f4198004c40) -> Pointer #13 freed (56 + 1 bytes)
[Core]          _webui_free_port([55763])
[Core]          _webui_free_mem(0x0x7f419c003d30)
[Core]          _webui_free_mem(0x0x7f419c003d30) -> Pointer #9 freed (64 + 1 bytes)
[Core]          _webui_server_thread([1]) -> Server stopped.
[Core]          _webui_make_window_reusable(1)
[Core]          _webui_server_thread([1]) -> Breaking main loop...
[Core]          _webui_condition_signal()
[Core]          _webui_wv_exit_schedule() -> Quit GTK Main Loop...
[Loop] _webui_wait_clean(Blocking) -> Cleaning...
[Core]          _webui_wv_free()
[Core]          _webui_wv_free() -> Unload WebKit
[Core]          _webui_wv_free() -> Unload GTK
Neoprávněný přístup do paměti (SIGSEGV)                  (core dumped [obraz paměti uložen]) /home/gordon/Dokumenty/PlatformIO/webui/build/minimal