Skip to content

Commit 010b36b

Browse files
umherirrenderWMDE bot
authored andcommitted
lib: Use type declaration on undocumented private functions
Change-Id: Ieee119e678d8993ea15a8fd9efb4a301375d0c3a
1 parent bc16ca1 commit 010b36b

10 files changed

Lines changed: 14 additions & 14 deletions

src/Deserializers/ItemDeserializer.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ public function deserialize( $serialization ) {
7777
return $this->getDeserialized( $serialization );
7878
}
7979

80-
private function getDeserialized( array $serialization ) {
80+
private function getDeserialized( array $serialization ): Item {
8181
$item = new Item();
8282

8383
$this->setIdFromSerialization( $serialization, $item );

src/Deserializers/ReferenceDeserializer.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public function isDeserializerFor( $serialization ) {
3737
return $this->isValidSerialization( $serialization );
3838
}
3939

40-
private function isValidSerialization( $serialization ) {
40+
private function isValidSerialization( $serialization ): bool {
4141
return is_array( $serialization ) && array_key_exists( 'snaks', $serialization );
4242
}
4343

src/Deserializers/SiteLinkDeserializer.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ private function getDeserialized( array $serialization ) {
5353
);
5454
}
5555

56-
private function getDeserializeBadges( array $serialization ) {
56+
private function getDeserializeBadges( array $serialization ): array {
5757
if ( !array_key_exists( 'badges', $serialization ) ) {
5858
return [];
5959
}
@@ -66,7 +66,7 @@ private function getDeserializeBadges( array $serialization ) {
6666
return $badges;
6767
}
6868

69-
private function deserializeItemId( $serialization ) {
69+
private function deserializeItemId( $serialization ): ItemId {
7070
$itemId = $this->entityIdDeserializer->deserialize( $serialization );
7171

7272
if ( !( $itemId instanceof ItemId ) ) {

src/Serializers/PropertySerializer.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ public function serialize( $object ) {
7373
return $this->getSerialized( $object );
7474
}
7575

76-
private function getSerialized( Property $property ) {
76+
private function getSerialized( Property $property ): array {
7777
$serialization = [
7878
'type' => $property->getType(),
7979
'datatype' => $property->getDataTypeId(),

src/Serializers/ReferenceListSerializer.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public function serialize( $object ) {
5555
return $this->getSerialized( $object );
5656
}
5757

58-
private function getSerialized( ReferenceList $references ) {
58+
private function getSerialized( ReferenceList $references ): array {
5959
$serialization = [];
6060

6161
foreach ( $references as $reference ) {

src/Serializers/ReferenceSerializer.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,15 +57,15 @@ public function serialize( $object ) {
5757
return $this->getSerialized( $object );
5858
}
5959

60-
private function getSerialized( Reference $reference ) {
60+
private function getSerialized( Reference $reference ): array {
6161
return [
6262
'hash' => $reference->getHash(),
6363
'snaks' => $this->snaksSerializer->serialize( $reference->getSnaks() ),
6464
'snaks-order' => $this->buildSnakListOrderList( $reference->getSnaks() ),
6565
];
6666
}
6767

68-
private function buildSnakListOrderList( SnakList $snaks ) {
68+
private function buildSnakListOrderList( SnakList $snaks ): array {
6969
$list = [];
7070

7171
/**

src/Serializers/SiteLinkSerializer.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ public function serialize( $object ) {
4646
return $this->getSerialized( $object );
4747
}
4848

49-
private function getSerialized( SiteLink $siteLink ) {
49+
private function getSerialized( SiteLink $siteLink ): array {
5050
return [
5151
'site' => $siteLink->getSiteId(),
5252
'title' => $siteLink->getPageName(),

src/Serializers/SnakSerializer.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ public function serialize( $object ) {
6767
return $this->getSerialized( $object );
6868
}
6969

70-
private function getSerialized( Snak $snak ) {
70+
private function getSerialized( Snak $snak ): array {
7171
$serialization = [
7272
'snaktype' => $snak->getType(),
7373
'property' => $snak->getPropertyId()->getSerialization(),

src/Serializers/StatementSerializer.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ public function serialize( $object ) {
8080
return $this->getSerialized( $object );
8181
}
8282

83-
private function getSerialized( Statement $statement ) {
83+
private function getSerialized( Statement $statement ): array {
8484
$serialization = [
8585
'mainsnak' => $this->mainSnakSerializer->serialize( $statement->getMainSnak() ),
8686
'type' => 'statement',
@@ -115,7 +115,7 @@ private function addReferencesToSerialization( Statement $statement, array &$ser
115115
}
116116
}
117117

118-
private function addQualifiersToSerialization( Statement $statement, &$serialization ) {
118+
private function addQualifiersToSerialization( Statement $statement, array &$serialization ) {
119119
$qualifiers = $statement->getQualifiers();
120120

121121
if ( $qualifiers->count() !== 0 ) {
@@ -124,7 +124,7 @@ private function addQualifiersToSerialization( Statement $statement, &$serializa
124124
}
125125
}
126126

127-
private function buildQualifiersOrderList( SnakList $snaks ) {
127+
private function buildQualifiersOrderList( SnakList $snaks ): array {
128128
$list = [];
129129

130130
/**

src/Serializers/TypedSnakSerializer.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ private function assertIsSerializerFor( $object ) {
4747
}
4848
}
4949

50-
private function getSerialized( TypedSnak $typedSnak ) {
50+
private function getSerialized( TypedSnak $typedSnak ): array {
5151
$serialization = $this->snakSerializer->serialize( $typedSnak->getSnak() );
5252

5353
$serialization['datatype'] = $typedSnak->getDataTypeId();

0 commit comments

Comments
 (0)