Skip to content

Commit cbf5db5

Browse files
coddersWMDE bot
authored andcommitted
Reenable documentation sniffs
Keep silencing the sniffs in tests to reduce noise. (That exclusion could be kept indefinitely, or addressed later) Bug: T330644 Change-Id: Ie54947ebd3650976c0c5569408e690ad9b039e38
1 parent 8827158 commit cbf5db5

4 files changed

Lines changed: 6 additions & 2 deletions

File tree

src/Diff/ItemDiffer.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ private function assertIsItemAndCast( EntityDocument $item ): Item {
6262
return $item;
6363
}
6464

65-
public function diffItems( Item $from, Item $to ) {
65+
public function diffItems( Item $from, Item $to ): ItemDiff {
6666
$diffOps = $this->recursiveMapDiffer->doDiff(
6767
$this->toDiffArray( $from ),
6868
$this->toDiffArray( $to )

src/Diff/PropertyDiffer.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ private function assertIsPropertyAndCast( EntityDocument $property ): Property {
6262
return $property;
6363
}
6464

65-
public function diffProperties( Property $from, Property $to ) {
65+
public function diffProperties( Property $from, Property $to ): EntityDiff {
6666
$diffOps = $this->diffPropertyArrays(
6767
$this->toDiffArray( $from ),
6868
$this->toDiffArray( $to )

src/EntityId/InMemoryEntityIdPager.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,12 @@ public function fetchIds( $limit ) {
5050
return $entityIds;
5151
}
5252

53+
/** @inheritDoc */
5354
public function getPosition() {
5455
return $this->offset;
5556
}
5657

58+
/** @inheritDoc */
5759
public function setPosition( $position ) {
5860
$this->offset = $position;
5961
}

src/Lookup/InMemoryEntityLookup.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,10 +104,12 @@ private function throwExceptionIfNeeded( EntityId $entityId ) {
104104
}
105105
}
106106

107+
/** @inheritDoc */
107108
public function getItemForId( ItemId $itemId ) {
108109
return ( new LegacyAdapterItemLookup( $this ) )->getItemForId( $itemId );
109110
}
110111

112+
/** @inheritDoc */
111113
public function getPropertyForId( PropertyId $propertyId ) {
112114
return ( new LegacyAdapterPropertyLookup( $this ) )->getpropertyForId( $propertyId );
113115
}

0 commit comments

Comments
 (0)