Skip to content

README mentions Android packagingOptions for RN >= 0.59, but FabricExample does not include it #1007

@fxamauri

Description

@fxamauri

Hi, thanks for maintaining this library.

I noticed a discrepancy between the README and the current FabricExample setup.

In the README, the Android installation section states that for React Native 0.59.0 and above we should add the following to android/app/build.gradle

packagingOptions {
    pickFirst 'lib/x86/libc++_shared.so'
    pickFirst 'lib/x86_64/libjsc.so'
    pickFirst 'lib/arm64-v8a/libjsc.so'
    pickFirst 'lib/arm64-v8a/libc++_shared.so'
    pickFirst 'lib/x86_64/libc++_shared.so'
    pickFirst 'lib/armeabi-v7a/libc++_shared.so'
}

However, the current FabricExample/android/app/build.gradle on master does not include this block.

Could you clarify what the expected setup is today?

  • Is this configuration still required for recent versions of React Native / react-native-pdf?
  • If so, should FabricExample be updated to include
  • If not, could the README be updated to remove it or scope it to specific versions?

thanks.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions