Formatting of multi-line function/event calls

[grigorescu]

Currently, we have a script in base with the following:

info$store = Broker::create_clone(info$name,
                                  info$clone_resync_interval,
                                  info$clone_stale_interval,
                                  info$clone_mutation_buffer_interval);

The formatter tries to re-format it to:

info$store = Broker::create_clone(info$name, info$clone_resync_interval,
    info$clone_stale_interval, info$clone_mutation_buffer_interval);

I find the first version much more readable. Any other thoughts?

[JustinAzoff]

I personally prefer

info$store = Broker::create_clone(
    info$name,
    info$clone_resync_interval,
    info$clone_stale_interval,
    info$clone_mutation_buffer_interval,
);

but I might be in the minority here :-)

[grigorescu]

I don't mind that style, @JustinAzoff, but what you typed generates a parsing error, due to the last comma. (Whether or not it should be is a separate discussion).

Given that, I think I prefer the last line having the close parens and semicolon. It seems like it'd be an easy trap to fall into of re-arranging parameters and missing the fact that the last one must have no comma. The parens makes it a bit more explicit.