Fix some warnings

Author: StefH

src/Microsoft.EntityFrameworkCore.DynamicLinq.EFCore3/EFDynamicQueryableExtensions.cs

@@ -419,7 +419,7 @@ private static Type EmitType(IList<DynamicProperty> properties, bool createParam
 
         EmitEqualityOperators(typeBuilder, equals);
 
-        return typeBuilder.CreateType();
+        return typeBuilder.CreateType()!;
     }
 
     private static void EmitEqualityOperators(TypeBuilder typeBuilder, MethodBuilder equals)

src/System.Linq.Dynamic.Core/DynamicClassFactory.cs

@@ -189,7 +189,7 @@ public static LambdaExpression ParseLambda(bool createParameterCtor, Type itType
         Check.NotNull(itType);
         Check.NotEmpty(expression);
 
-        return ParseLambda(createParameterCtor, new[] { ParameterExpressionHelper.CreateParameterExpression(itType, string.Empty) }, resultType, expression, values);
+        return ParseLambda(createParameterCtor, [ParameterExpressionHelper.CreateParameterExpression(itType, string.Empty)], resultType, expression, values);
     }
 
     /// <summary>
@@ -207,7 +207,8 @@ public static Expression<Func<T, TResult>> ParseLambda<T, TResult>(ParsingConfig
     {
         Check.NotEmpty(expression);
 
-        return (Expression<Func<T, TResult>>)ParseLambda(parsingConfig, createParameterCtor, new[] { ParameterExpressionHelper.CreateParameterExpression(typeof(T), string.Empty, parsingConfig?.RenameEmptyParameterExpressionNames ?? false) }, typeof(TResult), expression, values);
+        return (Expression<Func<T, TResult>>)ParseLambda(parsingConfig, createParameterCtor, [ParameterExpressionHelper.CreateParameterExpression(typeof(T), string.Empty, parsingConfig?.RenameEmptyParameterExpressionNames ?? false)
+        ], typeof(TResult), expression, values);
     }
 
     /// <summary>
@@ -227,7 +228,8 @@ public static Expression<Func<T, TResult>> ParseLambda<T, TResult>(Type delegate
         Check.NotNull(delegateType);
         Check.NotEmpty(expression);
 
-        return (Expression<Func<T, TResult>>)ParseLambda(delegateType, parsingConfig, createParameterCtor, new[] { ParameterExpressionHelper.CreateParameterExpression(typeof(T), string.Empty, parsingConfig?.RenameEmptyParameterExpressionNames ?? false) }, typeof(TResult), expression, values);
+        return (Expression<Func<T, TResult>>)ParseLambda(delegateType, parsingConfig, createParameterCtor, [ParameterExpressionHelper.CreateParameterExpression(typeof(T), string.Empty, parsingConfig?.RenameEmptyParameterExpressionNames ?? false)
+            ], typeof(TResult), expression, values);
     }
 
     /// <summary>
@@ -374,7 +376,7 @@ public static LambdaExpression ParseLambda(Type delegateType, ParsingConfig? par
         Check.NotNull(itType);
         Check.NotEmpty(expression);
 
-        return ParseLambda(delegateType, parsingConfig, createParameterCtor, new[] { ParameterExpressionHelper.CreateParameterExpression(itType, string.Empty, parsingConfig?.RenameEmptyParameterExpressionNames ?? false) }, resultType, expression, values);
+        return ParseLambda(delegateType, parsingConfig, createParameterCtor, [ParameterExpressionHelper.CreateParameterExpression(itType, string.Empty, parsingConfig?.RenameEmptyParameterExpressionNames ?? false)], resultType, expression, values);
     }
 
     /// <summary>

src/System.Linq.Dynamic.Core/DynamicExpressionParser.cs

@@ -2094,7 +2094,7 @@ public static IQueryable SelectMany(
             string collectionParameterName,
             string resultParameterName,
             object?[]? collectionSelectorArgs = null,
-            params object[]? resultSelectorArgs)
+            params object?[]? resultSelectorArgs)
         {
             Check.NotNull(source);
             Check.NotNull(config);

src/System.Linq.Dynamic.Core/DynamicQueryableExtensions.cs

@@ -2,46 +2,45 @@
 using System.Collections.Generic;
 using System.Globalization;
 
-namespace System.Linq.Dynamic.Core
+namespace System.Linq.Dynamic.Core;
+
+/// <summary>
+/// The result of a call to a <see cref="DynamicQueryableExtensions"/>.GroupByMany() overload.
+/// </summary>
+public class GroupResult
 {
     /// <summary>
-    /// The result of a call to a <see cref="DynamicQueryableExtensions"/>.GroupByMany() overload.
+    /// The key value of the group.
     /// </summary>
-    public class GroupResult
-    {
-        /// <summary>
-        /// The key value of the group.
-        /// </summary>
 #if NET35 || SILVERLIGHT
-        public object Key { get; internal set; } = null!;
+    public object Key { get; internal set; } = null!;
 #else
-        public dynamic Key { get; internal set; } = null!;
+    public dynamic Key { get; internal set; } = null!;
 #endif
 
-        /// <summary>
-        /// The number of resulting elements in the group.
-        /// </summary>
-        public int Count { get; internal set; }
+    /// <summary>
+    /// The number of resulting elements in the group.
+    /// </summary>
+    public int Count { get; internal set; }
 
-        /// <summary>
-        /// The resulting elements in the group.
-        /// </summary>
-        public IEnumerable Items { get; internal set; }
+    /// <summary>
+    /// The resulting elements in the group.
+    /// </summary>
+    public IEnumerable Items { get; internal set; } = null!;
 
-        /// <summary>
-        /// The resulting subgroups in the group.
-        /// </summary>
-        public IEnumerable<GroupResult>? Subgroups { get; internal set; }
+    /// <summary>
+    /// The resulting subgroups in the group.
+    /// </summary>
+    public IEnumerable<GroupResult>? Subgroups { get; internal set; }
 
-        /// <summary>
-        /// Returns a <see cref="System.String" /> showing the key of the group and the number of items in the group.
-        /// </summary>
-        /// <returns>
-        /// A <see cref="System.String" /> that represents this instance.
-        /// </returns>
-        public override string ToString()
-        {
-            return string.Format(CultureInfo.CurrentCulture, "{0} ({1})", ((object)Key).ToString(), Count);
-        }
+    /// <summary>
+    /// Returns a <see cref="System.String" /> showing the key of the group and the number of items in the group.
+    /// </summary>
+    /// <returns>
+    /// A <see cref="System.String" /> that represents this instance.
+    /// </returns>
+    public override string ToString()
+    {
+        return string.Format(CultureInfo.CurrentCulture, "{0} ({1})", ((object)Key).ToString(), Count);
     }
 }

src/System.Linq.Dynamic.Core/GroupResult.cs

@@ -1,12 +1,13 @@
 using System.Linq.Expressions;
 using System.Reflection;
 
-namespace System.Linq.Dynamic.Core.Parser.SupportedMethods
+namespace System.Linq.Dynamic.Core.Parser.SupportedMethods;
+
+internal class MethodData(MethodBase methodBase, ParameterInfo[] parameters)
 {
-    internal class MethodData
-    {
-        public MethodBase MethodBase { get; set; }
-        public ParameterInfo[] Parameters { get; set; }
-        public Expression[] Args { get; set; }
-    }
-}
+    public MethodBase MethodBase => methodBase;
+
+    public ParameterInfo[] Parameters => parameters;
+
+    public Expression[] Args { get; set; } = [];
+}

src/System.Linq.Dynamic.Core/Parser/SupportedMethods/MethodData.cs

@@ -170,7 +170,7 @@ public int FindBestMethodBasedOnArguments(IEnumerable<MethodBase> methods, ref E
         var inlineArgs = args;
 
         MethodData[] applicable = methods
-            .Select(m => new MethodData { MethodBase = m, Parameters = m.GetParameters() })
+            .Select(m => new MethodData(m, m.GetParameters()))
             .Where(m => IsApplicable(m, inlineArgs))
             .ToArray();
 

src/System.Linq.Dynamic.Core/Parser/SupportedMethods/MethodFinder.cs

@@ -48,7 +48,7 @@ public Expression Rename(Expression expression, out ParameterExpression? paramet
         return visitedExpression;
     }
 
-    /// <inheritdoc cref="ExpressionVisitor.VisitParameter"/>
+    /// <inheritdoc />
     protected override Expression VisitParameter(ParameterExpression node)
     {
         if (string.Equals(_oldName, node.Name, StringComparison.Ordinal))