Replace String.Format with StringBuilder for Estimated FPS#925
Merged
aHooder merged 4 commits into117HD:masterfrom Feb 26, 2026
Merged
Replace String.Format with StringBuilder for Estimated FPS#925aHooder merged 4 commits into117HD:masterfrom
aHooder merged 4 commits into117HD:masterfrom
Conversation
Member
|
Can you check this out with IntelliJ's profiler again? 🙂 I figured since Regarding the extra math functions, I'm not too sure if they'll actually be useful, but I suppose we just want any general math function in there, so it's probably fine. Not too hard to review at least 🙂 |
Added Round(v, n) to be able to round to a set amount of decimal places
Since this is just gonna keep coming back to bite us, this is a decent compromise I think. We don't *really* need the speed, mostly just allocation reduction is nice.
RuffledPlume
force-pushed
the
EstimatedFPSFormatting
branch
from
6475ff6 to
8f4c9ac
Compare
Contributor
Author
Its no longer a hotspot of memory allocations, compared to the rest of the frame
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced String.Format with StringBuilder for Estimated FPS, which significantly reduces garbage generated with the frameTimer open.
Added Round(v, n) to be able to round to a set amount of decimal places
Along with the different permutations of the function
Master:
PR:
