Shadow Shading, Fade Out, Per Quality Shadow Bias & Optimization#952
Closed
RuffledPlume wants to merge 12 commits into117HD:masterfrom
Closed
Shadow Shading, Fade Out, Per Quality Shadow Bias & Optimization#952RuffledPlume wants to merge 12 commits into117HD:masterfrom
RuffledPlume wants to merge 12 commits into117HD:masterfrom
Conversation
8d88d42 to
11e6364
Compare
* Renable Smoothstep Fadeout on Shadows
* Added Shadow Shading Config
* Smooth (Default)
* Dithered
* Pixilated
* Unrolled the Shadow PCF
* Added Early out, where if the 4 corners of the kernal are fully in shadow then we can save 5 texelFetches
* Defined a bias per shadow Quality Level
* Added Support for shadowAlphaMap in the Material
11e6364 to
828861a
Compare
0a7106a to
93c9116
Compare
Member
|
This looks good to me 🙂. I think we should still consider whether we want to support shadow distance and expand shadow draw. I've noticed on rare occasions, expand shadow draw still prevents pop-in, but I'm not sure how significant the cost is anymore. |
0bc86be to
300a864
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the shadow bounds calculations have been improved, we can renable the fadeout since it no longer fades out the shadow when zoomed in on the player
Main Branch:
2026-02-24.21-39-45.mp4
PR Branch:
2026-02-24.21-40-42.mp4