fix: handle HTML responses in panel management API requests#12264
Open
jakub961241 wants to merge 1 commit into1Panel-dev:dev-v2from
Open
fix: handle HTML responses in panel management API requests#12264jakub961241 wants to merge 1 commit into1Panel-dev:dev-v2from
jakub961241 wants to merge 1 commit into1Panel-dev:dev-v2from
Conversation
…ev#12260) When adding a remote panel, the API may return HTML (e.g., 401 login page) instead of JSON. The code attempted to unmarshal HTML as JSON, causing: "json umarshal resp data failed, err: invalid character '<'" Changes: - Read response body before status check to include it in errors - Add explicit 401 Unauthorized handling with clear error message - Validate Content-Type is JSON before attempting unmarshal - Include response preview in error for easier debugging Fixes 1Panel-dev#12260
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12260 - Multi-machine management fails when adding a panel with error:
Root Cause
When the remote panel returns a 401 Unauthorized response, it sends an HTML page (
401.html) withContent-Type: text/html. The code atcore/utils/req_helper/proxy_local/req_to_local.goattempted tojson.Unmarshal()this HTML, causing theinvalid character '<'error.Fix
Changed file
core/utils/req_helper/proxy_local/req_to_local.go