fix: resolve bash not found on minimal OS installs#12266
Open
jakub961241 wants to merge 1 commit into1Panel-dev:dev-v2from
Open
fix: resolve bash not found on minimal OS installs#12266jakub961241 wants to merge 1 commit into1Panel-dev:dev-v2from
jakub961241 wants to merge 1 commit into1Panel-dev:dev-v2from
Conversation
On minimal OS installations (e.g., AlmaLinux 10), bash may not be in the default $PATH, causing snapshot restore and other operations to fail with: exec: "bash": executable file not found in $PATH Add BashPath() helper that uses exec.LookPath first, then falls back to checking /bin/bash, /usr/bin/bash, /usr/local/bin/bash. Applied to both core and agent cmd packages and all callers. Fixes 1Panel-dev#12257
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12257 - Snapshot restore fails on AlmaLinux 10 with:
Root Cause
exec.Command("bash", ...)is used throughout the codebase, but on minimal OS installs (AlmaLinux, some RHEL-based),bashis not in the default$PATHeven though it exists at/bin/bashor/usr/bin/bash.Fix
Added
BashPath()helper function to bothcore/utils/cmdandagent/utils/cmdpackages:exec.LookPath("bash")(standard PATH lookup)/bin/bash,/usr/bin/bash,/usr/local/bin/bashsync.Oncefor performanceReplaced all
exec.Command("bash", ...)calls withexec.Command(BashPath(), ...)in:core/utils/cmd/cmd.gocore/utils/cmd/cmdx.gocore/utils/terminal/local_cmd.gocore/i18n/i18n.goagent/utils/cmd/cmd.goagent/utils/cmd/cmdx.go