feat: unify default server with default page options#12268
Open
jakub961241 wants to merge 1 commit into1Panel-dev:dev-v2from
Open
feat: unify default server with default page options#12268jakub961241 wants to merge 1 commit into1Panel-dev:dev-v2from
jakub961241 wants to merge 1 commit into1Panel-dev:dev-v2from
Conversation
Merge "Default Page" configuration into the "Default Server" dialog. Users can now choose between: - No default server - Default Page (with sub-options: Custom HTML, No Response 444, Redirect) - An existing website The "No Response (444)" option is useful for security when ports are scanned. The "Redirect" option allows redirecting unbound domains to a specific URL. The separate "Default HTML" button is kept for editing PHP, domain404, and stop pages which serve different purposes. Closes 1Panel-dev#12179
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #12179 - Merge "Default Page" into "Default Server" dialog with new options.
Changes
The "Default Server" dialog now offers three modes:
Default Page sub-options:
Changed files
frontend/src/views/website/website/default/index.vue- Unified dialog with page type optionsfrontend/src/lang/modules/en.ts- New translation keysfrontend/src/lang/modules/zh.ts- New translation keys (Chinese)Screenshots
The dialog now shows a dropdown with three choices. When "Default Page" is selected, sub-options appear for page type (Custom HTML / No Response / Redirect).