fix: code editor tab persistence and close behavior#12270
Open
jakub961241 wants to merge 1 commit into1Panel-dev:dev-v2from
Open
fix: code editor tab persistence and close behavior#12270jakub961241 wants to merge 1 commit into1Panel-dev:dev-v2from
jakub961241 wants to merge 1 commit into1Panel-dev:dev-v2from
Conversation
Three bugs fixed in the file management code editor: 1. Closing tabs didn't persist - removeTab() and removeAllTab() never called saveTabsToStorage(), so closed tabs would reappear on next editor open. 2. Last tab couldn't be closed - :closable condition required fileTabs.length > 1, preventing closing the last remaining tab. Changed to >= 1. Context menu (close all, etc.) also now shows for single tabs. 3. Missing watch import in tabs component caused reactivity issues with tab selection synchronization. Fixes 1Panel-dev#12098
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12098 - Three bugs in the file management code editor tabs.
Bug 1: Closed tabs reopen next time
removeTab()andremoveAllTab()modifiedfileTabs.valuebut never calledsaveTabsToStorage(), so the removal was never persisted to localStorage.Fix: Added
saveTabsToStorage()calls after every tab removal path (save+close, discard+close, direct close).Bug 2: Last tab can't be closed
:closablewas conditioned onfileTabs.length > 1, and the context menu (Close All, etc.) was hidden for single tabs.Fix: Changed to
>= 1so the close button and context menu are always available.Bug 3: Missing
watchimportwatchwas used intabs/index.vuebut not imported from Vue, causing tab selection sync issues.Changed files
frontend/src/views/host/file-management/code-editor/index.vue- Persist tab removal to localStoragefrontend/src/views/host/file-management/code-editor/tabs/index.vue- Allow closing last tab, fix watch import