fix: show Resources tab for reverse proxy websites#12271
Open
jakub961241 wants to merge 2 commits into1Panel-dev:dev-v2from
Open
fix: show Resources tab for reverse proxy websites#12271jakub961241 wants to merge 2 commits into1Panel-dev:dev-v2from
jakub961241 wants to merge 2 commits into1Panel-dev:dev-v2from
Conversation
The Resources tab (for managing linked databases) was only shown for 'runtime' and 'static' website types. Users who created a website with a database then switched to reverse proxy mode could not unlink or delete the database because the tab was hidden. Added 'proxy' to the v-if conditions in both: - config/basic/index.vue (tab visibility) - config/basic/resource/index.vue (database change form) Fixes 1Panel-dev#12139
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
The Stop button was disabled for apps in 'ReStarting' status because the condition only allowed 'Running'. Apps stuck in a restart loop (e.g., due to DB connection issues) could not be stopped. Added 'ReStarting' to the allowed statuses for the Stop operation. Closes 1Panel-dev#12061
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12139 - Reverse proxy websites don't show the "Resources" tab, so users can't unlink or switch databases.
Root Cause
The Resources tab
v-ifcondition only allowed'runtime'and'static'types:Proxy websites (
type === 'proxy') were excluded, making it impossible to manage linked databases.Fix
Added
|| website.type === 'proxy'to both conditions:config/basic/index.vue- tab pane visibilityconfig/basic/resource/index.vue- database change formChanged files
frontend/src/views/website/website/config/basic/index.vue(+1, -1)frontend/src/views/website/website/config/basic/resource/index.vue(+1, -1)