fix: auto theme does not update when OS switches day/night mode#12278
Open
jakub961241 wants to merge 1 commit into1Panel-dev:dev-v2from
Open
fix: auto theme does not update when OS switches day/night mode#12278jakub961241 wants to merge 1 commit into1Panel-dev:dev-v2from
jakub961241 wants to merge 1 commit into1Panel-dev:dev-v2from
Conversation
…l-dev#6813) When theme is set to "auto" (follow system), changing the OS from light to dark (or vice versa) without reloading the page had no effect. The theme was only evaluated once on page load. Added a matchMedia 'change' event listener that calls switchTheme() whenever the OS color scheme changes, but only when theme is "auto". Listener is properly cleaned up on component unmount. Fixes 1Panel-dev#6813 (point 1)
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6813 (point 1) - When theme is set to "auto" (follow system), the panel doesn't switch between dark/light mode when the OS changes without a page reload.
Root Cause
useTheme()infrontend/src/global/use-theme.tsonly evaluateswindow.matchMedia('(prefers-color-scheme: dark)').matcheswhenswitchTheme()is explicitly called. No listener is registered for thechangeevent on the media query.Fix
Added
matchMedia.addEventListener('change', ...)that callsswitchTheme()when the OS color scheme changes, but only when the theme setting is"auto". Listener is cleaned up viaonUnmounted.Changed file
frontend/src/global/use-theme.ts(+14)