fix: traffic chart spike after page blur and terminal scroll speed#12281
Open
jakub961241 wants to merge 1 commit into1Panel-dev:dev-v2from
Open
fix: traffic chart spike after page blur and terminal scroll speed#12281jakub961241 wants to merge 1 commit into1Panel-dev:dev-v2from
jakub961241 wants to merge 1 commit into1Panel-dev:dev-v2from
Conversation
…-dev#12067, 1Panel-dev#11911) Two fixes: 1. Traffic data spike after page blur (1Panel-dev#12067) When the page loses focus, polling pauses. On resume, accumulated network bytes divided by a small interval caused a massive spike. Now skips the first data point after resume (or when timeInterval > 10s), only updating counters without chart push. 2. Terminal scroll sensitivity inconsistency (1Panel-dev#11911) scrollSensitivity had 4 different defaults across the codebase: - Store: 10, Component: 15, Preview: 15, Reset: 6 Unified all to 5 (lower = less sensitive in xterm.js). Changed || to ?? so setting 0 is respected. Fixes 1Panel-dev#12067, 1Panel-dev#11911
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two bug fixes:
1. Traffic chart spike after page blur (#12067)
When switching to another tab, polling pauses. On return, accumulated network bytes create a massive spike in the chart.
Fix: Skip the first chart data point after resuming from blur (detected by
skipNextChartflag ortimeInterval > 10s). Only updates the raw counters without pushing to the chart arrays.2. Terminal mouse wheel scrolls too fast (#11911)
scrollSensitivityhad 4 different default values across the codebase:Fix: Unified all to 5 and changed
||to??so that setting 0 (the minimum) is properly respected.Changed files
frontend/src/views/home/index.vue- Skip chart update after blurfrontend/src/components/terminal/index.vue- Fix fallback valuefrontend/src/store/modules/terminal.ts- Fix store defaultfrontend/src/views/terminal/setting/index.vue- Fix preview and reset defaults