Skip to content

feat: change openclaw upgrade logic#12324

Closed
zhengkunwang223 wants to merge 1 commit intodev-v2from
pr@dev-v2@agent
Closed

feat: change openclaw upgrade logic#12324
zhengkunwang223 wants to merge 1 commit intodev-v2from
pr@dev-v2@agent

Conversation

@zhengkunwang223
Copy link
Member

No description provided.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 25, 2026

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 25, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign wanghe-fit2cloud for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2cb6279d6f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

if strings.TrimSpace(fromVersion) != openclawHTTPSVersion {
return false
}
return common.CompareVersion(strings.TrimSpace(toVersion), openclawHTTPSVersion)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Treat latest tags as eligible for Caddyfile rewrite

This gate uses common.CompareVersion on toVersion, but that comparator returns false for non-numeric versions like latest. The codebase already treats latest/non-numeric app versions as valid upgrade targets (for example in OpenClaw HTTPS version checks), so an upgrade from 2026.3.13 to latest will skip the Caddyfile rewrite and keep the stale file this change is trying to replace.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants