Remove image letterboxing (extent + background)#7
Open
aaronsmulktis wants to merge 1 commit intomasterfrom
Open
Remove image letterboxing (extent + background)#7aaronsmulktis wants to merge 1 commit intomasterfrom
aaronsmulktis wants to merge 1 commit intomasterfrom
Conversation
The extent + background: 'snow2' options were padding all product images to exact square dimensions with an off-white background, creating visible letterboxing. Images now keep their natural aspect ratio after resize — frontends use CSS object-fit: cover to fill their containers. Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extent: sizeandbackground: 'snow2'from all image variant methods (styles,style,plp_url)object-fit: coverto fill containers, so no visual change needed downstreamBefore
Images resized to fit within e.g. 600x600, then padded to exactly 600x600 with
snow2(off-white) background — creating visible letterboxing on dark-themed storefronts.After
Images resized to fit within max dimensions, keeping natural aspect ratio. No padding, no background fill.
Note
Existing cached ActiveStorage variants in S3 will still have the old letterboxing until they expire or are purged.
🤖 Generated with Claude Code
via Happy