feat: extract kill operation to core/operations/kill.ts#105
feat: extract kill operation to core/operations/kill.ts#1052witstudios wants to merge 3 commits intomainfrom
Conversation
Move agent kill logic from commands/kill.ts into a reusable core/operations/kill.ts module. The CLI command is now a thin wrapper that handles arg parsing and output formatting, delegating all kill logic to performKill(). Closes #61
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- P1: Remove unused listSessionPanes import
- P2: Add success field to KillResult; return success:false for
self-protection (restores original JSON contract)
- P2: Restore info("Killing agent X") progress messages in command layer
- P2: Replace fragile vi.restoreAllMocks with vi.clearAllMocks +
explicit mock defaults in beforeEach
- P3: Add worktreeCount to KillResult for kill-all message context
- P3: Fix 0-killed message when all agents skipped in worktree kill
- P3: Add manifest mutation verification tests (status=gone, delete)
- P3: Add --remove on --all test and error propagation test
- P3: Fix --all open PR skip warning in command output
1 participant
Summary
commands/kill.tsintocore/operations/kill.tswith aperformKill()functioncommands/kill.tssimplified to arg parsing + output formatting (~90 lines, down from ~335)performKill()returns a structuredKillResultobject, making it reusable by conductors and other callersTest plan
npm run typecheckpasses (pre-existing errors only)npm test— all 210 tests pass (pre-existing cron-parser failures only)kill.test.ts— 17 tests all passingCloses #61