Skip to content

feat: implement Settings views#119

Open
2witstudios wants to merge 3 commits intomainfrom
ppg/issue-86-settings-views
Open

feat: implement Settings views#119
2witstudios wants to merge 3 commits intomainfrom
ppg/issue-86-settings-views

Conversation

@2witstudios
Copy link
Owner

Summary

  • SettingsView.swift — full server management: server list with connect/tap, swipe-to-delete with confirmation dialog, test connection button with async success/failure feedback, QR scanner sheet integration, connection status badge, about section with dynamic app version and GitHub link
  • AddServerView.swift — dedicated form view for manual server entry (name, host, port, token) with input validation, replacing the limited alert-based approach

Acceptance Criteria

  • Server list with add/delete
  • QR scanner button (launches QRScannerView, parses result, adds connection)
  • Test connection button with success/failure feedback
  • Server deletion with confirmation dialog
  • About section (app version, links)
  • Manual entry form (name, host, port, token)

Dependencies

Closes #86

- SettingsView: server list with connect/disconnect, swipe-to-delete with
  confirmation dialog, test connection button with async feedback, QR scanner
  sheet, connection status badge, about section with version and GitHub link
- AddServerView: dedicated form for manual server entry (name, host, port,
  token) with validation, replacing the limited alert-based approach

Closes #86
@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai
Copy link

coderabbitai bot commented Feb 27, 2026

Warning

Rate limit exceeded

@2witstudios has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 10 minutes and 19 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 34deb69 and 75ec34a.

📒 Files selected for processing (3)
  • ios/PPGMobile/PPGMobile/Views/Settings/AddServerView.swift
  • ios/PPGMobile/PPGMobile/Views/Settings/SettingsView.swift
  • src/commands/spawn.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ppg/issue-86-settings-views

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

- P0: fix GitHub URL from jongravois to 2witstudios
- P1: add @mainactor to testConnection Task, guard against race with
  Task.isCancelled check before clearing result
- P2: use SecureField with show/hide toggle for token input
- P2: show alert when QR scan fails to parse a valid ppg:// URL
- P3: display error message text in test connection failure state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Settings views

1 participant