refactor: abstract tmux into ProcessManager interface#144
Open
2witstudios wants to merge 2 commits intomainfrom
Open
refactor: abstract tmux into ProcessManager interface#1442witstudios wants to merge 2 commits intomainfrom
2witstudios wants to merge 2 commits intomainfrom
Conversation
Introduce a ProcessManager interface that abstracts tmux operations behind a backend-agnostic API, enabling future support for alternative process managers (e.g. ConPTY on Windows). - Add src/core/process-manager.ts with ProcessManager interface and types - Add TmuxBackend class to tmux.ts implementing ProcessManager - Add src/core/backend.ts factory with getBackend()/setBackend()/resetBackend() - Add src/core/conpty.ts experimental ConPTY stub using node-pty - Update all imports across 25+ production files and 10+ test files - Add platform branching to terminal.ts (macOS/Windows/Linux)
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (112)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProcessManagerinterface (src/core/process-manager.ts) that abstracts all tmux operations behind a backend-agnostic APITmuxBackendclass tosrc/core/tmux.tsimplementing the interface by delegating to existing functionssrc/core/backend.tsfactory withgetBackend()/setBackend()/resetBackend()and platform detection (win32 → ConPTY, else → tmux)ConPtyBackendstub (src/core/conpty.ts) usingnode-ptyas optional dependencygetBackend()callsterminal.ts— macOS (Terminal.app), Windows (wt.exe), Linux ($TERMINAL with gnome-terminal/konsole/xterm fallbacks)Test plan
npm run typecheckpasses (only pre-existingwstype errors remain)npm test— 631/632 tests pass; the 1 failure (serveDaemonCommand) is pre-existingbackend.jsinstead oftmux.jsppg spawn,ppg status,ppg killwork as before