Enforce changelog entry on new PR #1569
Open
+33
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josemigallas
changed the title
josemigallas
reviewed
Feb 3, 2026
| - name: Check changelog existence | ||
| if: steps.changelog-file.outputs.any_changed == 'false' | ||
| run: | | ||
| echo("Please include a CHANGELOG entry. You can find it at [CHANGELOG.md](https://github.com/3scale/apicast/blob/master/CHANGELOG.md)." |
There was a problem hiding this comment.
Suggested change
| echo("Please include a CHANGELOG entry. You can find it at [CHANGELOG.md](https://github.com/3scale/apicast/blob/master/CHANGELOG.md)." | |
| echo "Please include a CHANGELOG entry. You can find it at [CHANGELOG.md](https://github.com/3scale/apicast/blob/master/CHANGELOG.md)." |
josemigallas
reviewed
Feb 3, 2026
|
|
||
| jobs: | ||
| require-changelog: | ||
| if: ${{ !contains(github.event.*.labels.*.name, 'skip-changelog') }} |
There was a problem hiding this comment.
Would this be correct?
Suggested change
| if: ${{ !contains(github.event.*.labels.*.name, 'skip-changelog') }} | |
| if: ${{ !contains(github.event.pull_request.labels.*.name, 'skip-changelog') }} |
Contributor
Author
There was a problem hiding this comment.
I don't know 😄 , let me try
josemigallas
reviewed
Feb 3, 2026
| pull_request: | ||
| types: [ opened, synchronize, labeled, unlabeled ] | ||
| paths: | ||
| - 'gateway/**' |
Contributor
Author
There was a problem hiding this comment.
Because we only care about whether the source code changes or not, everything else is optional; that is, I don't think we need an entry in CHANGELOG just because we change the CI config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Enfore changelog entry on new PR