Open
Conversation
0a48d93 to
7b86470
Compare
Perseus14
reviewed
Apr 8, 2026
Perseus14
reviewed
Apr 8, 2026
Perseus14
reviewed
Apr 8, 2026
Perseus14
reviewed
Apr 8, 2026
Collaborator
Perseus14
left a comment
There was a problem hiding this comment.
Overall looks good. Few minor comments.
Please add few results comparing baseline and this branch to get a better idea of the improvements.
4ae0dff to
c5bb862
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes for the LTX2 pipeline:
flash_min_seq_lengthparameter to config file, now the choice of attention is controlled by this parameter. Experimentally observed that having dot attention for audio to audio self attn and video to audio cross attn and flash for audio to video provided more speed up. We had to hardcode "flash" as the attention choice for audio to video, because the way the attention mechanism is currently decided bases on flash min seq length compares the seq length for all q, k/v and flash is chosen only if all have seq length > flash min seq length. Experimentally we observed more speed ups if audio to video was kept in flash instead of dot.scheduling_flow_match_flax.pyResults
We performed the experiments below for dp = 2, cp = 2, tp = 2, fsdp = 1, per device batch size = 0.125