Skip to content

Standardize SFT model interface with TunixMaxTextAdapter#3584

Draft
igorts-git wants to merge 1 commit intomainfrom
igorts/sft-adapter-standardization
Draft

Standardize SFT model interface with TunixMaxTextAdapter#3584
igorts-git wants to merge 1 commit intomainfrom
igorts/sft-adapter-standardization

Conversation

@igorts-git
Copy link
Copy Markdown
Collaborator

Description

Overview

This PR refactors train_sft to wrap the model with TunixMaxTextAdapter that is currently used in train_rl to convert model argument names between Tunix and MaxText. This is needed as a preparation work for adding support of DPO.

Tests

  • Successfully ran a 2-step SFT job with gemma2-2b to confirm the naming translation works correctly.
  • Verified that the model interface remains compatible with existing SFT configurations.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@igorts-git igorts-git force-pushed the igorts/sft-adapter-standardization branch from 0e0fa46 to 0bf4907 Compare April 7, 2026 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant