Using synthetic dataset_type for more cases#3591
Open
charlesli640 wants to merge 1 commit intoAI-Hypercomputer:mainfrom
Open
Using synthetic dataset_type for more cases#3591charlesli640 wants to merge 1 commit intoAI-Hypercomputer:mainfrom
charlesli640 wants to merge 1 commit intoAI-Hypercomputer:mainfrom
Conversation
charlesli640
requested review from
A9isha,
NicoGrande,
NuojCheng,
RissyRan,
SurbhiJainUSC,
aireenmei,
bvandermoon,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
igorts-git,
jesselu-google,
jiangjy1982,
khatwanimohit,
richjames0,
shralex,
suexu1025 and
vipannalla
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
bvandermoon
approved these changes
Apr 7, 2026
| @pytest.mark.tpu_only | ||
| def test_tpu_tokamax(self): | ||
| train_main(TrainTests.CONFIGS["base"] + ["use_tokamax_splash=true"]) | ||
| train_main(TrainTests.CONFIGS["synthetic"] + ["use_tokamax_splash=true"]) |
Collaborator
There was a problem hiding this comment.
Why does the synthetic config set dataset_path?
Collaborator
Author
There was a problem hiding this comment.
dataset_path will be ignored if dataset_type is synthetic. As the data will be actually created in memory instead of loaded from the path. I guess it was set by copy-and-paste. But it does no harm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Using synthetic dataset_type for more cases to speed up CI workflow
Tests
CI workflow on github
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.