Fix Metric Reporting Crash (ZeroDivisionError) using Tunix PerfTracer#3597
Draft
igorts-git wants to merge 1 commit intomainfrom
Draft
Fix Metric Reporting Crash (ZeroDivisionError) using Tunix PerfTracer#3597igorts-git wants to merge 1 commit intomainfrom
igorts-git wants to merge 1 commit intomainfrom
Conversation
09067b5 to
966e6dd
Compare
966e6dd to
953990b
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
953990b to
f3d4232
Compare
f3d4232 to
abcb6e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a ZeroDivisionError that occurred in the MaxText MetricLogger during Tunix-based SFT runs.
The Problem
As the result of Tunix PR1289. The Tunix library's internal training loop now hard-codes the step time to zero when calling the
on_train_step_endhook.The MaxText SFT hook passes the zero value to the
metric_logger.The MetricLogger divides FLOPS and tokens values by the passed zero
step_time.The Tunix change was made because the old reported step_time metric was inaccurate due to async execution. The recommended solution was to use Tunix
PerfTracer, which correctly tracks the async step time.The Fix
FIXES: b/497665859.
Tests
Manual invocation of SFT training with and without the fix with Tunix installed from main/HEAD.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.