Skip to content

Remove no exp usage from logical rule Part III#3606

Draft
NuojCheng wants to merge 5 commits intomainfrom
chengnuojin-no-exp3
Draft

Remove no exp usage from logical rule Part III#3606
NuojCheng wants to merge 5 commits intomainfrom
chengnuojin-no-exp3

Conversation

@NuojCheng
Copy link
Copy Markdown
Collaborator

@NuojCheng NuojCheng commented Apr 8, 2026

Description

Followup PR of #3578 and #3603

Deprecate following logical names:

  • embed_no_exp
  • embed_no_exp_moe

Tests

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@NuojCheng NuojCheng added the draft Draft PR label Apr 8, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

❌ Patch coverage is 40.74074% with 32 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/maxtext/layers/moe.py 6.45% 29 Missing ⚠️
src/maxtext/layers/attention_op.py 87.50% 1 Missing ⚠️
src/maxtext/layers/decoders.py 66.66% 1 Missing ⚠️
src/maxtext/layers/nnx_decoders.py 50.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

draft Draft PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant