[slice] Refactor OwnerPodsFinished#1172
Open
pajakd wants to merge 1 commit intoAI-Hypercomputer:slice-mainfrom
Open
[slice] Refactor OwnerPodsFinished#1172pajakd wants to merge 1 commit intoAI-Hypercomputer:slice-mainfrom
pajakd wants to merge 1 commit intoAI-Hypercomputer:slice-mainfrom
Conversation
PBundyra
reviewed
Apr 8, 2026
| ownerObj = &jobset.JobSet{} | ||
| podLabelKey = jobset.JobSetNameKey | ||
| logKey = "jobSet" | ||
| ownerKind = "JobSet" |
Collaborator
There was a problem hiding this comment.
Can we use a constants from the JobSet API?
PBundyra
reviewed
Apr 8, 2026
| } else if utilworkload.IsJobOwner(wl) { | ||
| owner = metav1.GetControllerOf(wl) | ||
| ownerObj = &batchv1.Job{} | ||
| podLabelKey = "batch.kubernetes.io/job-name" |
Collaborator
There was a problem hiding this comment.
Can we use a constant here?
PBundyra
reviewed
Apr 8, 2026
| if err := r.client.List(ctx, pods, opts...); err != nil { | ||
| log.Error(err, "Failed to get Pods") | ||
| return false, err | ||
| if utilworkload.IsJobSetOwner(wl) { |
Collaborator
There was a problem hiding this comment.
It just a nit but I believe in Go it's a good practice to use switch-case statements in such cases
Collaborator
|
Besides just a few nits, LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Instead of having 3 functions jobSetPodsFinished, jobPodsFinished and lwsPodsFinished lets have a single one that receives the owner kind and reference as an argument.
Issue
Testing