Removed invalid modifiers and assigned them#2
Merged
lvanfretti merged 1 commit intoALSETLab:UniversityCampusMicrogrid_1from Oct 18, 2025
Merged
Removed invalid modifiers and assigned them#2lvanfretti merged 1 commit intoALSETLab:UniversityCampusMicrogrid_1from
lvanfretti merged 1 commit intoALSETLab:UniversityCampusMicrogrid_1from
Conversation
Four parameter modifiers were not targeting the correct/updated parameter name. For example, V_AMIN was changed to VA_MIN in the AC7B model, and thus, the modifier should be applied to VA_MIN instead. This was done to other 3 parameters.
lvanfretti
merged commit f247da4
into
ALSETLab:UniversityCampusMicrogrid_1
2 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four parameter modifiers were not targeting the correct/updated parameter name. For example, V_AMIN was changed to VA_MIN in the AC7B model, and thus, the modifier should be applied to VA_MIN instead. This was done to other 3 parameters.