Open
Conversation
Update bios.hpp with clang-19-format to clean up a bit before adding code to support amd-clear-cmos.sh in 2x1P. Signed-off-by: don owens <Donald.Owens@amd.com>
Add in support for redfish to clear CMOS in 2x1P mode. Tested: Verified on Nigeria Signed-off-by: don owens <Donald.Owens@amd.com>
aasboddu
approved these changes
Feb 7, 2026
aasboddu
requested changes
Feb 7, 2026
srgovard
approved these changes
Feb 9, 2026
aasboddu
reviewed
Feb 9, 2026
| } | ||
|
|
||
| // convert host string to argument for the cmos reset script | ||
| if (hostStr == "0") |
Collaborator
There was a problem hiding this comment.
@dono-amd have you confirmed that this is working for the 1P or 2P case.
In 1P or 2P we need to pass hostStr as 0 to the script because the power control D-Bus API in script use Chassis0 and chassis0 as input. Also can we remove the string and add as uint8_t for consistency? It is the same for other URI that use multi-host mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bmcweb: Add 2x1P CMOS redfish reset
Add in support for redfish to clear CMOS in 2x1P mode.
Tested: Verified on Nigeria