[WIP] Hook the exact Riemann solver into Castro#2908
Open
zingale wants to merge 52 commits intoAMReX-Astro:developmentfrom
Open
[WIP] Hook the exact Riemann solver into Castro#2908zingale wants to merge 52 commits intoAMReX-Astro:developmentfrom
zingale wants to merge 52 commits intoAMReX-Astro:developmentfrom
Conversation
this will make it easier to use this for non-castro things (like exact_riemann)
…ro into exact_riemann_castro_params
now they have "riemann" in their name, and also some drop "cg" so that it is clear that they can apply to other solvers
allow the exact Riemann solver to use the new constants
zingale
changed the title
Member
Author
|
addresses #2285 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
The main implementation of the exact Riemann solver is moved from Util/exact_riemann
into Source/hydro to allow us to use it directly in simulations.
PR motivation
PR checklist
CHANGESfile has been updated, if appropriate