Fix avifDecSampleTransformItemValidateProperties()#3013
Fix avifDecSampleTransformItemValidateProperties()#3013wantehchang merged 3 commits intoAOMediaCodec:mainfrom
Conversation
|
Yannis: I tried to review this PR last week, but the PR is a little long, so I didn't finish the review. Could you please rebase the PR and resolve the conflicts? Thanks. |
y-guyon
force-pushed
the
satogrid
branch
2 times, most recently
from
b5ebee2 to
511dddf
Compare
Done. Thanks for taking a look! |
|
Yannis: There is a merge error. The new commit has the wrong commit message: |
Good catch. I wonder how I messed |
wantehchang
left a comment
wantehchang
left a comment
There was a problem hiding this comment.
LGTM. Thanks! I am not familiar with the code, so I didn't try to fully understand the changes.
Return BMFF_PARSE_FAILED intead of INTERNAL_ERROR on missing ispe. Implement TODO about verifying av1C consistency. Fix comment wrongly referring to item being a grid instead of a sato. Also add an extra check in avifPropertyArrayFind().
wantehchang
left a comment
wantehchang
left a comment
There was a problem hiding this comment.
LGTM. Thanks! Just one final suggestion.
| default: | ||
| assert(AVIF_FALSE); | ||
| return NULL; | ||
| return kUnknown; // Easier to deal with than NULL. |
There was a problem hiding this comment.
[Just a comment, not a request for change.] If avifGetConfigurationPropertyName() returns NULL here, the caller can detect that it is an unknown codec type. But none of the callers check the return value, so returning a "****" string is more convenient.
2 participants
Return BMFF_PARSE_FAILED intead of INTERNAL_ERROR on missing ispe.
Implement TODO about verifying av1C consistency.
Fix comment wrongly referring to item being a grid instead of a sato.