Simplifying the split delta allocation computation#14
Merged
Conversation
jmvalin
force-pushed
the
jmvalin/theta_cleanup
branch
from
226eb18 to
c2ccc64
Compare
Directly approximating log2(tan(x)) instead of going through the sin/cos
Further simplifies the split delta
jmvalin
force-pushed
the
jmvalin/theta_cleanup
branch
from
c2ccc64 to
c664c9e
Compare
|
Looks cleaner, makes sense to me. It is a bit exact change, right? |
Contributor
Author
|
The code is equivalent, but not bitexact. Both versions are computing log2(tan(x)), but the approximations differ slightly. |
phill-williams
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.