Skip to content

Adding STMAG and AB mag to flux conversion#48

Closed
lbardou wants to merge 4 commits intoAOtools:mainfrom
lbardou:master
Closed

Adding STMAG and AB mag to flux conversion#48
lbardou wants to merge 4 commits intoAOtools:mainfrom
lbardou:master

Conversation

@lbardou
Copy link
Copy Markdown

@lbardou lbardou commented Aug 2, 2019

No description provided.

@matthewtownson matthewtownson self-assigned this Aug 2, 2019
@matthewtownson
Copy link
Copy Markdown
Member

Hi @lbardou,

There is something wrong with our Python 3.5 tests, but there is an error from the Python 2.7 test (see below). Apart from that this looks great!

======================================================================
947ERROR: test_astronomy.test_flux_star_type
948----------------------------------------------------------------------
949Traceback (most recent call last):
950  File "/home/travis/miniconda3/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
951    self.test(*self.arg)
952  File "/home/travis/build/AOtools/aotools/test/test_astronomy.py", line 48, in test_flux_star_type
953    flux = astronomy.flux_star_type(10, 'H', 'A0V', 1.1, 0.2)
954  File "/home/travis/build/AOtools/aotools/aotools/astronomy/_astronomy.py", line 133, in flux_star_type
955    wavelengths = erg_spec[:, 0] * 1e-4
956IndexError: too many indices for array
957-------------------- >> begin captured logging << --------------------
958urllib3.connectionpool: DEBUG: Starting new HTTP connection (1): vizier.u-strasbg.fr:80
959urllib3.connectionpool: DEBUG: http://vizier.u-strasbg.fr:80 "POST /viz-bin/votable HTTP/1.1" 200 3675
960--------------------- >> end captured logging << ---------------------

@matthewtownson matthewtownson added the stale Over 1 year of inactivity, schedule for closing. label Dec 7, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 12, 2026

Codecov Report

❌ Patch coverage is 97.36842% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.23%. Comparing base (f584549) to head (c3dda1f).
⚠️ Report is 142 commits behind head on main.

Files with missing lines Patch % Lines
aotools/astronomy/_astronomy.py 97.22% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
+ Coverage   95.17%   95.23%   +0.05%     
==========================================
  Files          25       26       +1     
  Lines        1224     1260      +36     
==========================================
+ Hits         1165     1200      +35     
- Misses         59       60       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale Over 1 year of inactivity, schedule for closing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants