Merged
Conversation
leahkiner
force-pushed
the
feature/1332-new-facet-srp-effector-module
branch
from
8f62d83 to
4a975ac
Compare
Contributor
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4a975ac706
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
leahkiner
force-pushed
the
feature/1332-new-facet-srp-effector-module
branch
from
4a975ac to
b6eb459
Compare
schaubh
changed the title
schaubh
requested changes
Mar 29, 2026
Contributor
schaubh
left a comment
schaubh
left a comment
There was a problem hiding this comment.
Nice PR. Mostly small stuff to address.
leahkiner
force-pushed
the
feature/1332-new-facet-srp-effector-module
branch
4 times, most recently
from
e7827d6 to
93b8d06
Compare
schaubh
requested changes
Apr 14, 2026
Contributor
schaubh
left a comment
schaubh
left a comment
There was a problem hiding this comment.
just some minor stuff now.
leahkiner
force-pushed
the
feature/1332-new-facet-srp-effector-module
branch
from
93b8d06 to
c3b6343
Compare
schaubh
approved these changes
Apr 14, 2026
Contributor
schaubh
left a comment
schaubh
left a comment
There was a problem hiding this comment.
All good to go! Thanks for the nice work on this module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This new faceted solar radiation pressure dynamic effector module is created to utilize the two new modules recently added to the repository:
facetedSpacecraftModelandfacetedSpacecraftProjectedArea. The originalfacetSRPDynamicEffectormodule is complicated in that it contains several different calculations which are now isolated and checked in these new modules. This new SRP module now perform a compact SRP calculation that does not include any auxiliary calculations.Description
This module computes the aggregate force and torque acting on the spacecraft due to impinging photons from the Sun. The inertial Sun state information must be subscribed to the module
SpicePlanetStateMsgPayloadinput message. The module assumes the spacecraft is modeled as a collection of facets, where the facet geometry information is passed as a vector ofFacetElementBodyMsgPayloadinput messages to the module. The facet geometry information is required to be provided in the spacecraft body frame. This SRP module does not make any assumptions regarding whether the facets are rigid or articulate. ThefacetedSpacecraftModelmodule can be connected upstream and used to transform the facet geometry data from the facet frames to the spacecraft body frame. This upstream module can also be used to configure articulating facets.Finally, this SRP module also requires the sunlit area of all facets to be pre-computed and connected to the module vector ofProjectedAreaMsgPayloadinput messages. This information can be passed to the SRP module by connecting the facet geometry information to thefacetedSpacecraftProjectedAreamodule upstream.Verification
The module unit test verifies that the module correctly computes the aggregate SRP force and torque acting on the spacecraft due to impinging photons from the Sun. The test sets up a simulation with a faceted spacecraft modeled as a cubic hub with two attached circular solar arrays. Six square facets represent the cubic hub and four circular facets represent the two solar arrays. The test varies the initial state information of the spacecraft, the initial state information of the Sun, and the Sun illumination factor.
Documentation
RST documentation is added for the new module.
Future work
N/A