Conversation
modloader/modconfig.py
Outdated
| mods[-1][3] += "\n\nVerified by {}".format(verified.username.replace("<postmaster@example.com>", "")) | ||
| else: | ||
| print "NOT VALID SIG", mod | ||
| print "NOT VALID SIG", mod[1] # Note: printing only the mod name, instead of the whi=ole thing SIGNIFICANTLY speeds up this call |
There was a problem hiding this comment.
This is slightly worrying - how many mods don't have a valid signature? I thought I'd signed most of them
There was a problem hiding this comment.
These 15 fail, though I haven't checked why
(3336106514) ALL WORKING MODS! 32 (Flight of Love doesn't show)
(3651582794) Angels With Scaly Wings: Chinese Simplified
(3666234554) Card Game Expanded 卡牌游戏增强（Two Languages Support）
(2801825863) Casual Arson
(2697982171) Casual Vandalism
(2096774388) Lorem_RPG
(2742645268) MagmaClient
(2990207385) Meet Naomi
(1305731599) Modtools
(2766323849) Name Re-entry
(3465212790) Naomi Maze Skip
(2736325690) Skip Credits
(2987066957) The Morning After
(3645564443) The Traitor
(3657449256) Vykoupení
There was a problem hiding this comment.
Most of those I can't remember anyone asking to sign, though I have signed 2 recently. The modtools itself is actually never signed so that's fine
There was a problem hiding this comment.
Ah, that's fair. I'm still hesitant to return the printing to how it was, As it seems to double the runtime of the validity check (from ~2 seconds to ~5 seconds)...
As for the modtools, I'll add a special case for it (to be ignored)
| print "Called cached queryAPI with page={}".format(page) | ||
|
|
||
| # Get most recent cache file if exists | ||
| cache_file_name = self.get_cache_filename(page) |
There was a problem hiding this comment.
Why are we storing a cache in a file rather than say in memory?
Given that it expires in 15 minutes, that's not particularly useful for multiple play sessions
There was a problem hiding this comment.
The issue I was running into (which was the main one preventing the game from starting) Was that repeated calls to QueryApi failed silently, and in doing so, crashed the game. Once these start to fail, they keep failing even between play sessions until about 15 minutes pass, which prevents anything from accessing the modlist until that time passes. Therefore, I use a file to store those results, as they need to be accessible between play sessions.
I've added a description of this in the PR's description, as this is the most significant change.
There was a problem hiding this comment.
That's really weird and I'm not sure what to make of it to be honest
There was a problem hiding this comment.
Yeah... I only found it by trying to isolate the issues with CachePersonas (mainly why it crashes silently and abruptly), and found it really weird that QueryApi itself can cause it...
I do wonder if it happens just on my machine of is it a more widespread thing. I'd appreciate it if you can check if it also happens on yours (I did so by replacing the content of CachePersonas with a single call to QueryApi(1). Then I started the game, quit out of the main menu, then tried to start it again, which failed by this issue.).
It'd be quite interesting if it's just a localized thing on my machine...
modloader/steamhandler_ex.py
Outdated
| cPickle.dump(tuple(islice(array, arr_len)), cache_file) | ||
|
|
||
| except Exception as e: | ||
| print "Cache callback raised Exception:", str(e) |
There was a problem hiding this comment.
I honestly don't remember, I think it's a holdover from testing? We can reraise, or just remove the except case altogether.
There was a problem hiding this comment.
Just try/finally is probably fine here if there's nothing we actually want to handle
There was a problem hiding this comment.
If this callback fails I think it should be logged though? As it's a call that shouldn't fail under normal circumstances, and it's failure can be very problematic... But I guess I should still say as such in the code, as it currently seems quite random
There was a problem hiding this comment.
If the callback fails, it should probably cause an error screen to show up right?
There was a problem hiding this comment.
I guess so. I've committed such update.
… using the new SteamModlist class to manage this.
…ils to work. Added exception handling functionality to modlist preload.
2 participants
Added pagination to the in-game mod browser, along with fixing certain issues regarding to getting modlists from steam.
Main Changes
Fixed
steamhandler'sQueryApimethodThis method, which is used to get sections of the modlist from steam's API, has a tendency to crash silently on repeated calls, which also crashes the game. The source of this crash seems to be related to steam caching these results, as these crashes persist between play sessions, and occur consistently from the second call onwards for about 15 minutes after a successful call.
This was solved by created an on-disk cache of this method's results, and using that cache until that 15-minute interval elapses, which allows the
QueryApicalls to never use the problematic steam cache.Added pagination to the In-game mod browser
With the increasing number of mods available in the game since the development on the browser, both load time and navigation go slower as a consequence of the longer modlist. pagination was then added to both allow partial loading of the modlist, and to allow quicker navigation of the modlist.
Load speed improvements
The critical path of getting the modlist (which defines the content of the browser) has been examined, and certain optimizations have been made. of those there are: