Skip to content

WIP - Issue #1186: Add enabled Flag to Transitions#1308

Draft
visajshah wants to merge 2 commits intoAcademySoftwareFoundation:mainfrom
visajshah:enableTransitionB
Draft

WIP - Issue #1186: Add enabled Flag to Transitions#1308
visajshah wants to merge 2 commits intoAcademySoftwareFoundation:mainfrom
visajshah:enableTransitionB

Conversation

@visajshah
Copy link
Copy Markdown
Contributor

This PR fixes #1186.

Created the enabled flag for Transition based on what was implemented in the case of Item.

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented May 20, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: visajshah / name: Visaj Nirav Shah (c90830c)

@visajshah visajshah changed the title Issue #1186: Add enabled Flag to Transitions WIP - Issue #1186: Add enabled Flag to Transitions May 20, 2022
visajshah added 2 commits May 21, 2022 00:12
Signed-off-by: Visaj Nirav Shah <visaj.shah@gmail.com>
Signed-off-by: Visaj Nirav Shah <visaj.shah@gmail.com>
@visajshah visajshah force-pushed the enableTransitionB branch from c131a45 to 5c4521e Compare May 20, 2022 18:43
@jminor
Copy link
Copy Markdown
Collaborator

jminor commented May 20, 2022

@visajshah you're the first person to use the new EasyCLA system on OpenTimelineIO since we moved the repo to ASWF. Did the process of signing the new CLA go okay? Was any of it confusing?

Copy link
Copy Markdown
Collaborator

@jminor jminor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a unit test for this? Especially one that confirms that older OTIO files without the flag result in a Transition which is enabled.
Also could you add some doc strings so that the new property have an explanation in the documentation?

@visajshah
Copy link
Copy Markdown
Contributor Author

@visajshah you're the first person to use the new EasyCLA system on OpenTimelineIO since we moved the repo to ASWF. Did the process of signing the new CLA go okay? Was any of it confusing?

@jminor, Yes, it was easy and straightforward. No issues faced.

@visajshah
Copy link
Copy Markdown
Contributor Author

Could you add a unit test for this? Especially one that confirms that older OTIO files without the flag result in a Transition which is enabled. Also could you add some doc strings so that the new property have an explanation in the documentation?

Noted, @jminor. I am still working on the main issue; hence I added WIP (Work in Progress). Once done, I will also create the required tests and add to the documentation.

@JeanChristopheMorinPerso
Copy link
Copy Markdown
Member

@visajshah visajshah marked this pull request as draft May 23, 2022 18:14
@visajshah
Copy link
Copy Markdown
Contributor Author

@jminor jminor added the roadmap label Jun 9, 2023
@jminor jminor added help wanted We're looking for help from the community - you're weclome to volunteer! devdays25 labels Sep 12, 2025
@jminor
Copy link
Copy Markdown
Collaborator

jminor commented Sep 12, 2025

Tagging this with devdays25 in the hopes that someone can continue this work. @visajshah you're welcome to continue too if you're still interested :)

@knownasred
Copy link
Copy Markdown

Hi!

I'd love to help get this PR across the finish line. @visajshah, are you still interested in continuing, or would you be open to me picking it up?

@apetrynet
Copy link
Copy Markdown
Contributor

I don't know exactly how to proceed, but I would say it should be fine if you want to pick this up @knownasred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted We're looking for help from the community - you're weclome to volunteer! roadmap

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add enabled Flag to Transitions

5 participants