WIP - Issue #1186: Add enabled Flag to Transitions#1308
WIP - Issue #1186: Add enabled Flag to Transitions#1308visajshah wants to merge 2 commits intoAcademySoftwareFoundation:mainfrom
Conversation
|
|
Signed-off-by: Visaj Nirav Shah <visaj.shah@gmail.com>
Signed-off-by: Visaj Nirav Shah <visaj.shah@gmail.com>
c131a45 to
5c4521e
Compare
|
@visajshah you're the first person to use the new EasyCLA system on OpenTimelineIO since we moved the repo to ASWF. Did the process of signing the new CLA go okay? Was any of it confusing? |
jminor
left a comment
There was a problem hiding this comment.
Could you add a unit test for this? Especially one that confirms that older OTIO files without the flag result in a Transition which is enabled.
Also could you add some doc strings so that the new property have an explanation in the documentation?
@jminor, Yes, it was easy and straightforward. No issues faced. |
Noted, @jminor. I am still working on the main issue; hence I added WIP (Work in Progress). Once done, I will also create the required tests and add to the documentation. |
|
@visajshah GitHub supports what's called draft PRs, see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-stage-of-a-pull-request#converting-a-pull-request-to-a-draft. This let's everyone know that a PR is WIP without relying on the title. |
Thank you, @JeanChristopheMorinPerso. Done. |
|
Tagging this with |
|
Hi! I'd love to help get this PR across the finish line. @visajshah, are you still interested in continuing, or would you be open to me picking it up? |
|
I don't know exactly how to proceed, but I would say it should be fine if you want to pick this up @knownasred. |
This PR fixes #1186.
Created the
enabledflag forTransitionbased on what was implemented in the case ofItem.