fix: realpath on windows changed behavior in python 3.8 to expand mapped drive letters to their UNC path names#1856
Open
cfxegbert wants to merge 3 commits intoAcademySoftwareFoundation:mainfrom
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1856 +/- ##
==========================================
+ Coverage 59.30% 59.31% +0.01%
==========================================
Files 126 126
Lines 17210 17217 +7
Branches 3015 3016 +1
==========================================
+ Hits 10206 10212 +6
- Misses 6319 6320 +1
Partials 685 685 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ped drive letters to their UNC path names Signed-off-by: Robert Minsk <robertminsk@yahoo.com>
Signed-off-by: Robert Minsk <robertminsk@yahoo.com>
Signed-off-by: Robert Minsk <robertminsk@yahoo.com>
af36a1a to
0903ec3
Compare
Contributor
|
Nice, I found the same issue and was going to patch on my side |
Contributor
|
@JeanChristopheMorinPerso Can either this or #1543 be reviewed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1438
os.path.realpathon Python 3.8 Windows changed. When resolving mapped drive realpath returns the UNC path without the drive letter.This pull restores the Python 3.7 Windows behavior of
realpathbeing a wrapper aroundabspath. The behavior can be changed with the rezconfig settingwindows_unc_path