Open
Conversation
Lin-Mao
reviewed
Feb 25, 2026
| std::string line; | ||
| while (std::getline(fin, line)) { | ||
| trim(line); | ||
| if (line.empty() || line[0] == '#') continue; // 跳过空行与注释 |
Contributor
There was a problem hiding this comment.
Suggested change
| if (line.empty() || line[0] == '#') continue; // 跳过空行与注释 | |
| if (line.empty() || line[0] == '#') continue; // skip empty lines or comments |
| if (it->second) { | ||
| SANITIZER_SAFECALL(sanitizerUnpatchModule(module)); | ||
| it->second = false; | ||
| if (it != sanitizer_active_modules.end()) { |
Contributor
There was a problem hiding this comment.
it won't be sanitizer_active_modules.end() because kernel should be launched on a active module.
| it->second = false; | ||
| if (it != sanitizer_active_modules.end()) { | ||
| if (it->second) { | ||
| // SANITIZER_SAFECALL(sanitizerUnpatchModule(module)); |
Contributor
There was a problem hiding this comment.
Suggested change
| // SANITIZER_SAFECALL(sanitizerUnpatchModule(module)); | |
| SANITIZER_SAFECALL(sanitizerUnpatchModule(module)); |
| host_tracker_handle->numEntries = 0; | ||
| host_tracker_handle->access_buffer = device_access_buffer; | ||
|
|
||
| uint32_t num_threads = |
Contributor
There was a problem hiding this comment.
GPU_PATCH_TIME_HOTNESS_CPU doesn't need to use doorBell to check if the kernel is finished.
This is bring error to tool time_hotness_cpu
Line 596-600 can be removed
| PRINT("[SANITIZER ERROR] Invalid target block format: %s\n", target_block_str); | ||
| exit(EXIT_FAILURE); | ||
| } | ||
| if (host_tracker_handle->target_block[0] < 0 || host_tracker_handle->target_block[1] < 0 || host_tracker_handle->target_block[2] < 0) { |
| PRINT("[SANITIZER INFO] Malloc memory %p with size %lu (flag: %u) on device %d\n", | ||
| (void*)pModuleData->address, pModuleData->size, pModuleData->flags, device_id); | ||
|
|
||
| PRINT("[SANITIZER INFO] Sector tag: %p, end tag: %p\n", (void*)(pModuleData->address >> 5), (void*)((pModuleData->address + pModuleData->size - 1) >> 5)); |
| PRINT("[SANITIZER INFO] Context %p creation finished on device %p\n", | ||
| &pContextData->context, &pContextData->device); | ||
|
|
||
| CUstream p_stream; |
Contributor
There was a problem hiding this comment.
It seems these data are not used, can we remove them?
| } | ||
| PRINT("[SANITIZER INFO] Alloc host memory %p with size %lu (flag: %u)\n", | ||
| (void*)pModuleData->address, pModuleData->size, pModuleData->flags); | ||
| PRINT("[SANITIZER INFO] Sector tag: %p, end tag: %p\n", (void*)(pModuleData->address >> 5), (void*)((pModuleData->address + pModuleData->size - 1) >> 5)); |
| uint64_t pc; | ||
| uint64_t size; | ||
| SANITIZER_SAFECALL(sanitizerGetFunctionPcAndSize(pLaunchData->module, pLaunchData->functionName, &pc, &size)); | ||
| PRINT("[SANITIZER INFO] Launching kernel %s <<<(%u, %u, %u), (%u, %u, %u)>>> on device %d, pc: 0x%lx, size: %lu\n", |
| uint64_t ctaId; | ||
| uint64_t pc; | ||
| uint32_t warpId; | ||
| uint32_t distinct_sector_count; |
Contributor
There was a problem hiding this comment.
Suggested change
| uint32_t distinct_sector_count; | |
| uint32_t distinct_sector_count; // for pc_dependency_analysis tool |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.