Prevent job history misclick on new image row#2002
Prevent job history misclick on new image row#2002
Conversation
|
The highlight not being at the right position could be improved. But I think to fix it properly means trying to rewrite the buttons displayed on top of thumbnails using perhaps QStyledItemDelegate subclass. This is a lot of work tweaking everything to look right on all sizes / thumbails aspect ratios / screen DPI etc. I really don't think it's worth it. Regarding misclicks: if you keep your history not scrolled to the bottom it won't auto-scroll, so no chance of misclicks. Or just wait until generation is done before deleting stuff. I admit I don't understand the need to constantly micro-manage the history in the first place, it's more like browser history. The discard option was mostly because people wanted to occasionally delete accidental / offensive generations. IMO this PR adds too much extra complexity and things that can go wrong, and I can imagine it being more annoying than helpful. |
Issue: Incorrect image deletion due to lag in job history UI causing mis-click
Conditions:
More Issue Details:
Fix discussion:
This does fix the issue for me, but the solution is a little ugly, requiring 3 different timers. Two to detect when the scroll to bottom and scroll range changed at the same time and one to guard against mis-clicking after that condition is detected. If you have a more elegant or simpler solution to this problem, let me know.