Open
Conversation
wrote the test but they are not running properly
Bmp phase three
better but needs improvements
CheezItMan
reviewed
Nov 13, 2016
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
@BrandiPhillips Looks good, you have some nice graphics on the homepage and the oAuth looks implemented well.
I like how you broke things out into partials. The only things not complete look like the tests, so overall well done. You've done well here.
| @@ -0,0 +1,10 @@ | |||
| <div class="top-bar"> | |||
There was a problem hiding this comment.
Nice turning your header into a partial form, similarly with the common footer.
| protect_from_forgery with: :exception | ||
|
|
||
| helper_method :current_user | ||
|
|
There was a problem hiding this comment.
Interesting use of the helper_method to make the current user available in the views.
Rgblish82
reviewed
Nov 14, 2020
| user = User.new | ||
| user.uid = auth_hash[:uid] | ||
| user.provider = 'github' | ||
| user.name = auth_hash['info']['name'] |
| user.uid = auth_hash[:uid] | ||
| user.provider = 'github' | ||
| user.name = auth_hash['info']['name'] | ||
| user.email = auth_hash['info']['email'] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@CheezItMan