Merged
Conversation
1. Remove unsafe 'as string' assertions on Supabase env vars (supabase.ts)
- VITE_SUPABASE_URL and VITE_SUPABASE_ANON_KEY were cast to string, hiding
the string | undefined type from TypeScript. The existing null-guard and
?? '' fallback on createClient() already handle the missing-var case;
removing the assertions lets the compiler enforce that handling correctly.
2. Add explicit radix to parseInt in CSV import (exportUtils.ts)
- parseInt(taskData.duration) without a radix relies on implicit base-10
inference. Added parseInt(taskData.duration, 10) to make intent explicit
and prevent any engine-specific octal/hex surprises.
3. Gate window debug helpers behind import.meta.env.DEV (supabase.ts)
- getDbCallStats, resetDbCallStats, and clearDbCallLog were attached to
window in all environments, exposing internal database call telemetry to
anyone with DevTools access in production. Now gated behind DEV so the
helpers are stripped from production bundles by Vite's tree-shaker.
https://claude.ai/code/session_012AmNjF3Ju9VJwSWybJqBEw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as stringassertions on env varsparseInt(value)toparseInt(value, 10)to prevent silent misparse of strings