Adding getStatus and getOutput methods to pvoutput-nodejs#1
Open
peterpeerdeman wants to merge 3 commits intoAdeptive:masterfrom
Open
Adding getStatus and getOutput methods to pvoutput-nodejs#1peterpeerdeman wants to merge 3 commits intoAdeptive:masterfrom
peterpeerdeman wants to merge 3 commits intoAdeptive:masterfrom
Conversation
…from pvoutput API
…in one single file
…getOutput methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for creating this project. I was looking for a package that implemented the pvoutput API and could only find your package. I have added calls for getStatus and getOutput, which use the same API credentials to retrieve the latest data about a system from the pvoutput API.
Could you maybe merge these changes in? I have not changed the original .send method so the changes are fully backwards compatible