Unit Tests: avoid hardcoding API version

src/test/java/com/adyen/BalanceControlTest.java

@@ -31,7 +31,11 @@ public void baseUrlOnTest() throws NoSuchFieldException, IllegalAccessException
     Field baseURLField = BalanceControlApi.class.getDeclaredField("baseURL");
     baseURLField.setAccessible(true);
     String baseURL = (String) baseURLField.get(balanceControlApi);
-    assertEquals("https://pal-test.adyen.com/pal/servlet/BalanceControl/v1", baseURL);
+    assertEquals(
+        String.format(
+            "https://pal-test.adyen.com/pal/servlet/BalanceControl/v%s",
+            BalanceControlApi.API_VERSION),
+        baseURL);
   }
 
   @Test
@@ -49,7 +53,10 @@ public void baseUrlOnLive() throws NoSuchFieldException, IllegalAccessException
     baseURLField.setAccessible(true);
     String baseURL = (String) baseURLField.get(balanceControlApi);
     assertEquals(
-        "https://myCompany-pal-live.adyenpayments.com/pal/servlet/BalanceControl/v1", baseURL);
+        String.format(
+            "https://myCompany-pal-live.adyenpayments.com/pal/servlet/BalanceControl/v%s",
+            BalanceControlApi.API_VERSION),
+        baseURL);
   }
 
   @Test
@@ -60,7 +67,9 @@ public void TestBalanceControlApi() throws IOException, ApiException, HTTPClient
 
     verify(client.getHttpClient())
         .request(
-            "https://pal-test.adyen.com/pal/servlet/BalanceControl/v1/balanceTransfer",
+            String.format(
+                "https://pal-test.adyen.com/pal/servlet/BalanceControl/v%s/balanceTransfer",
+                BalanceControlApi.API_VERSION),
             "{}",
             client.getConfig(),
             false,

src/test/java/com/adyen/BalancePlatformTest.java

@@ -31,7 +31,10 @@ public void baseUrlOnTest() throws NoSuchFieldException, IllegalAccessException
     Field baseURLField = PlatformApi.class.getDeclaredField("baseURL");
     baseURLField.setAccessible(true);
     String baseURL = (String) baseURLField.get(platformApi);
-    assertEquals("https://balanceplatform-api-test.adyen.com/bcl/v2", baseURL);
+    assertEquals(
+        String.format(
+            "https://balanceplatform-api-test.adyen.com/bcl/v%s", PlatformApi.API_VERSION),
+        baseURL);
   }
 
   @Test
@@ -43,7 +46,10 @@ public void baseUrlOnLive() throws NoSuchFieldException, IllegalAccessException
     Field baseURLField = PlatformApi.class.getDeclaredField("baseURL");
     baseURLField.setAccessible(true);
     String baseURL = (String) baseURLField.get(platformApi);
-    assertEquals("https://balanceplatform-api-live.adyen.com/bcl/v2", baseURL);
+    assertEquals(
+        String.format(
+            "https://balanceplatform-api-live.adyen.com/bcl/v%s", PlatformApi.API_VERSION),
+        baseURL);
   }
 
   @Test

src/test/java/com/adyen/BinLookupTest.java

@@ -49,7 +49,10 @@ public void baseUrlOnTest() throws NoSuchFieldException, IllegalAccessException
     Field baseURLField = BinLookupApi.class.getDeclaredField("baseURL");
     baseURLField.setAccessible(true);
     String baseURL = (String) baseURLField.get(binLookupApi);
-    assertEquals("https://pal-test.adyen.com/pal/servlet/BinLookup/v54", baseURL);
+    assertEquals(
+        String.format(
+            "https://pal-test.adyen.com/pal/servlet/BinLookup/v%s", BinLookupApi.API_VERSION),
+        baseURL);
   }
 
   @Test
@@ -66,7 +69,11 @@ public void baseUrlOnLive() throws NoSuchFieldException, IllegalAccessException
     Field baseURLField = BinLookupApi.class.getDeclaredField("baseURL");
     baseURLField.setAccessible(true);
     String baseURL = (String) baseURLField.get(binLookupApi);
-    assertEquals("https://myCompany-pal-live.adyenpayments.com/pal/servlet/BinLookup/v54", baseURL);
+    assertEquals(
+        String.format(
+            "https://myCompany-pal-live.adyenpayments.com/pal/servlet/BinLookup/v%s",
+            BinLookupApi.API_VERSION),
+        baseURL);
   }
 
   @Test

src/test/java/com/adyen/CheckoutTest.java

@@ -53,7 +53,8 @@ public void baseUrlOnTest() throws NoSuchFieldException, IllegalAccessException
     Field baseURLField = PaymentsApi.class.getDeclaredField("baseURL");
     baseURLField.setAccessible(true);
     String baseURL = (String) baseURLField.get(paymentsApi);
-    assertEquals("https://checkout-test.adyen.com/v71", baseURL);
+    assertEquals(
+        String.format("https://checkout-test.adyen.com/v%s", PaymentsApi.API_VERSION), baseURL);
   }
 
   @Test
@@ -70,7 +71,11 @@ public void baseUrlOnLive() throws NoSuchFieldException, IllegalAccessException
     Field baseURLField = PaymentsApi.class.getDeclaredField("baseURL");
     baseURLField.setAccessible(true);
     String baseURL = (String) baseURLField.get(paymentsApi);
-    assertEquals("https://myCompany-checkout-live.adyenpayments.com/checkout/v71", baseURL);
+    assertEquals(
+        String.format(
+            "https://myCompany-checkout-live.adyenpayments.com/checkout/v%s",
+            PaymentsApi.API_VERSION),
+        baseURL);
   }
 
   /** Should make a payment */
@@ -450,7 +455,9 @@ public void testLiveURLCheckout() throws Exception {
 
     verify(client.getHttpClient())
         .request(
-            "https://prefix-checkout-live.adyenpayments.com/checkout/v71/storedPaymentMethods/recurringId",
+            String.format(
+                "https://prefix-checkout-live.adyenpayments.com/checkout/v%s/storedPaymentMethods/recurringId",
+                RecurringApi.API_VERSION),
             null,
             client.getConfig(),
             false,
@@ -472,7 +479,9 @@ public void testLiveURLCheckoutWithSetEnviroment() throws Exception {
 
     verify(client.getHttpClient())
         .request(
-            "https://prefix-checkout-live.adyenpayments.com/checkout/v71/storedPaymentMethods/recurringId",
+            String.format(
+                "https://prefix-checkout-live.adyenpayments.com/checkout/v%s/storedPaymentMethods/recurringId",
+                RecurringApi.API_VERSION),
             null,
             client.getConfig(),
             false,
@@ -575,7 +584,7 @@ public void testPaymentWithRatepay() throws Exception {
 
     verify(client.getHttpClient())
         .request(
-            "https://checkout-test.adyen.com/v71/payments",
+            String.format("https://checkout-test.adyen.com/v%s/payments", PaymentsApi.API_VERSION),
             paymentRequest.toJson(),
             client.getConfig(),
             false,
@@ -648,7 +657,7 @@ public void testPaymentWithRiverty() throws Exception {
 
     verify(client.getHttpClient())
         .request(
-            "https://checkout-test.adyen.com/v71/payments",
+            String.format("https://checkout-test.adyen.com/v%s/payments", PaymentsApi.API_VERSION),
             paymentRequest.toJson(),
             client.getConfig(),
             false,
@@ -694,7 +703,9 @@ public void testSessionsCheckDefaultValues() throws Exception {
     final ArgumentCaptor<String> captor = ArgumentCaptor.forClass(String.class);
     verify(client.getHttpClient())
         .request(
-            eq("https://checkout-test.adyen.com/v71/sessions"),
+            eq(
+                String.format(
+                    "https://checkout-test.adyen.com/v%s/sessions", PaymentsApi.API_VERSION)),
             captor.capture(),
             any(com.adyen.Config.class),
             eq(false),
@@ -808,7 +819,9 @@ public void testPaymentWithIdempotencyKey() throws Exception {
     ArgumentCaptor<RequestOptions> optionsCaptor = ArgumentCaptor.forClass(RequestOptions.class);
     verify(client.getHttpClient())
         .request(
-            eq("https://checkout-test.adyen.com/v71/payments"),
+            eq(
+                String.format(
+                    "https://checkout-test.adyen.com/v%s/payments", PaymentsApi.API_VERSION)),
             isNotNull(),
             eq(client.getConfig()),
             eq(false),

src/test/java/com/adyen/DataProtectionServiceTest.java

@@ -44,7 +44,11 @@ public void baseUrlOnTest() throws NoSuchFieldException, IllegalAccessException
     Field baseURLField = DataProtectionApi.class.getDeclaredField("baseURL");
     baseURLField.setAccessible(true);
     String baseURL = (String) baseURLField.get(dataProtectionApi);
-    assertEquals("https://ca-test.adyen.com/ca/services/DataProtectionService/v1", baseURL);
+    assertEquals(
+        String.format(
+            "https://ca-test.adyen.com/ca/services/DataProtectionService/v%s",
+            DataProtectionApi.API_VERSION),
+        baseURL);
   }
 
   @Test
@@ -56,7 +60,11 @@ public void baseUrlOnLive() throws NoSuchFieldException, IllegalAccessException
     Field baseURLField = DataProtectionApi.class.getDeclaredField("baseURL");
     baseURLField.setAccessible(true);
     String baseURL = (String) baseURLField.get(dataProtectionApi);
-    assertEquals("https://ca-live.adyen.com/ca/services/DataProtectionService/v1", baseURL);
+    assertEquals(
+        String.format(
+            "https://ca-live.adyen.com/ca/services/DataProtectionService/v%s",
+            DataProtectionApi.API_VERSION),
+        baseURL);
   }
 
   /** Test success flow for POST /requestSubjectErasure */
@@ -72,7 +80,9 @@ public void TestRequestSubjectErasureSuccessMocked() throws Exception {
 
     verify(client.getHttpClient())
         .request(
-            "https://ca-test.adyen.com/ca/services/DataProtectionService/v1/requestSubjectErasure",
+            String.format(
+                "https://ca-test.adyen.com/ca/services/DataProtectionService/v%s/requestSubjectErasure",
+                DataProtectionApi.API_VERSION),
             "{}",
             client.getConfig(),
             false,

src/test/java/com/adyen/DisputesTest.java

@@ -25,7 +25,10 @@ public void baseUrlOnTest() throws NoSuchFieldException, IllegalAccessException
     Field baseURLField = DisputesApi.class.getDeclaredField("baseURL");
     baseURLField.setAccessible(true);
     String baseURL = (String) baseURLField.get(disputesApi);
-    assertEquals("https://ca-test.adyen.com/ca/services/DisputeService/v30", baseURL);
+    assertEquals(
+        String.format(
+            "https://ca-test.adyen.com/ca/services/DisputeService/v%s", DisputesApi.API_VERSION),
+        baseURL);
   }
 
   @Test
@@ -37,7 +40,10 @@ public void baseUrlOnLive() throws NoSuchFieldException, IllegalAccessException
     Field baseURLField = DisputesApi.class.getDeclaredField("baseURL");
     baseURLField.setAccessible(true);
     String baseURL = (String) baseURLField.get(disputesApi);
-    assertEquals("https://ca-live.adyen.com/ca/services/DisputeService/v30", baseURL);
+    assertEquals(
+        String.format(
+            "https://ca-live.adyen.com/ca/services/DisputeService/v%s", DisputesApi.API_VERSION),
+        baseURL);
   }
 
   @Test
@@ -54,9 +60,9 @@ public void acceptDispute() throws IOException, ApiException, HTTPClientExceptio
 
     verify(client.getHttpClient())
         .request(
-            "https://ca-test.adyen.com/ca/services/DisputeService/v"
-                + DisputesApi.API_VERSION
-                + "/acceptDispute",
+            String.format(
+                "https://ca-test.adyen.com/ca/services/DisputeService/v%s/acceptDispute",
+                DisputesApi.API_VERSION),
             request.toJson(),
             client.getConfig(),
             false,
@@ -82,9 +88,9 @@ public void defendDispute() throws IOException, ApiException, HTTPClientExceptio
 
     verify(client.getHttpClient())
         .request(
-            "https://ca-test.adyen.com/ca/services/DisputeService/v"
-                + DisputesApi.API_VERSION
-                + "/defendDispute",
+            String.format(
+                "https://ca-test.adyen.com/ca/services/DisputeService/v%s/defendDispute",
+                DisputesApi.API_VERSION),
             request.toJson(),
             client.getConfig(),
             false,
@@ -112,9 +118,9 @@ public void deleteDisputeDefenseDocument() throws IOException, ApiException, HTT
 
     verify(client.getHttpClient())
         .request(
-            "https://ca-test.adyen.com/ca/services/DisputeService/v"
-                + DisputesApi.API_VERSION
-                + "/deleteDisputeDefenseDocument",
+            String.format(
+                "https://ca-test.adyen.com/ca/services/DisputeService/v%s/deleteDisputeDefenseDocument",
+                DisputesApi.API_VERSION),
             request.toJson(),
             client.getConfig(),
             false,
@@ -141,9 +147,9 @@ public void retrieveApplicableDefenseReasons()
 
     verify(client.getHttpClient())
         .request(
-            "https://ca-test.adyen.com/ca/services/DisputeService/v"
-                + DisputesApi.API_VERSION
-                + "/retrieveApplicableDefenseReasons",
+            String.format(
+                "https://ca-test.adyen.com/ca/services/DisputeService/v%s/retrieveApplicableDefenseReasons",
+                DisputesApi.API_VERSION),
             request.toJson(),
             client.getConfig(),
             false,
@@ -211,9 +217,9 @@ public void supplyDefenseDocument() throws IOException, ApiException, HTTPClient
 
     verify(client.getHttpClient())
         .request(
-            "https://ca-test.adyen.com/ca/services/DisputeService/v"
-                + DisputesApi.API_VERSION
-                + "/supplyDefenseDocument",
+            String.format(
+                "https://ca-test.adyen.com/ca/services/DisputeService/v%s/supplyDefenseDocument",
+                DisputesApi.API_VERSION),
             request.toJson(),
             client.getConfig(),
             false,

src/test/java/com/adyen/LegalEntityManagementTest.java

@@ -28,7 +28,8 @@ public void baseUrlOnTest() throws NoSuchFieldException, IllegalAccessException
     Field baseURLField = LegalEntitiesApi.class.getDeclaredField("baseURL");
     baseURLField.setAccessible(true);
     String baseURL = (String) baseURLField.get(legalEntitiesApi);
-    assertEquals("https://kyc-test.adyen.com/lem/v4", baseURL);
+    assertEquals(
+        String.format("https://kyc-test.adyen.com/lem/v%s", LegalEntitiesApi.API_VERSION), baseURL);
   }
 
   @Test
@@ -40,7 +41,8 @@ public void baseUrlOnLive() throws NoSuchFieldException, IllegalAccessException
     Field baseURLField = LegalEntitiesApi.class.getDeclaredField("baseURL");
     baseURLField.setAccessible(true);
     String baseURL = (String) baseURLField.get(legalEntitiesApi);
-    assertEquals("https://kyc-live.adyen.com/lem/v4", baseURL);
+    assertEquals(
+        String.format("https://kyc-live.adyen.com/lem/v%s", LegalEntitiesApi.API_VERSION), baseURL);
   }
 
   @Test
@@ -277,7 +279,9 @@ public void BusinessLinesUpdateTest() throws Exception {
     assertEquals("string", response.getId());
     verify(client.getHttpClient())
         .request(
-            "https://kyc-test.adyen.com/lem/v4/businessLines/SE322KT223222D5FJ7TJN2986",
+            String.format(
+                "https://kyc-test.adyen.com/lem/v%s/businessLines/SE322KT223222D5FJ7TJN2986",
+                BusinessLinesApi.API_VERSION),
             request.toJson(),
             client.getConfig(),
             false,
@@ -388,7 +392,9 @@ public void DocumentsDeleteTest() throws Exception {
     service.deleteDocument("SE322KT223222D5FJ7TJN2986");
     verify(client.getHttpClient())
         .request(
-            "https://kyc-test.adyen.com/lem/v4/documents/SE322KT223222D5FJ7TJN2986",
+            String.format(
+                "https://kyc-test.adyen.com/lem/v%s/documents/SE322KT223222D5FJ7TJN2986",
+                DocumentsApi.API_VERSION),
             null,
             client.getConfig(),
             false,
@@ -428,7 +434,9 @@ public void HostedOnboardingPageRetrieveThemesTest() throws Exception {
     assertEquals("SE322KT223222D5FJ7TJN2986", response.getId());
     verify(client.getHttpClient())
         .request(
-            "https://kyc-test.adyen.com/lem/v4/themes/SE322KT223222D5FJ7TJN2986",
+            String.format(
+                "https://kyc-test.adyen.com/lem/v%s/themes/SE322KT223222D5FJ7TJN2986",
+                HostedOnboardingApi.API_VERSION),
             null,
             client.getConfig(),
             false,