[disputes] Code generation: update services and models#452
[disputes] Code generation: update services and models#452AdyenAutomationBot wants to merge 1 commit intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers automated updates to the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces automated changes to the disputes service, primarily updating endpoint string construction to use f-strings and reformatting method calls. While the intent seems to be modernization, the implementation has introduced some code style issues. The use of f-strings is not idiomatic in its current form, and the reformatting of call_adyen_api calls has resulted in lines that are excessively long, harming readability. My review includes suggestions to address these points by using f-strings more effectively and restoring the multi-line formatting for long method calls to adhere to common style practices.
| Accept a dispute | ||
| """ | ||
| endpoint = self.baseUrl + "/acceptDispute" | ||
| endpoint = self.baseUrl + f"/acceptDispute" |
There was a problem hiding this comment.
The f prefix on this string literal is redundant as there are no expressions to interpolate. This can be confusing for developers. For constructing URLs, it's more idiomatic to include the base URL variable within the f-string itself for better readability.
| endpoint = self.baseUrl + f"/acceptDispute" | |
| endpoint = f"{self.baseUrl}/acceptDispute" |
| return self.client.call_adyen_api( | ||
| request, self.service, method, endpoint, idempotency_key, **kwargs | ||
| ) | ||
| return self.client.call_adyen_api(request, self.service, method, endpoint, idempotency_key, **kwargs) |
There was a problem hiding this comment.
This line has become excessively long (over 100 characters), which harms readability and violates common Python style guidelines like PEP 8. The previous multi-line formatting was preferable. Please consider reformatting this call to span multiple lines.
| return self.client.call_adyen_api(request, self.service, method, endpoint, idempotency_key, **kwargs) | |
| return self.client.call_adyen_api( | |
| request, self.service, method, endpoint, idempotency_key, **kwargs | |
| ) |
| Defend a dispute | ||
| """ | ||
| endpoint = self.baseUrl + "/defendDispute" | ||
| endpoint = self.baseUrl + f"/defendDispute" |
There was a problem hiding this comment.
The f prefix on this string literal is redundant as there are no expressions to interpolate. This can be confusing for developers. For constructing URLs, it's more idiomatic to include the base URL variable within the f-string itself for better readability.
| endpoint = self.baseUrl + f"/defendDispute" | |
| endpoint = f"{self.baseUrl}/defendDispute" |
| return self.client.call_adyen_api( | ||
| request, self.service, method, endpoint, idempotency_key, **kwargs | ||
| ) | ||
| return self.client.call_adyen_api(request, self.service, method, endpoint, idempotency_key, **kwargs) |
There was a problem hiding this comment.
This line has become excessively long (over 100 characters), which harms readability and violates common Python style guidelines like PEP 8. The previous multi-line formatting was preferable. Please consider reformatting this call to span multiple lines.
| return self.client.call_adyen_api(request, self.service, method, endpoint, idempotency_key, **kwargs) | |
| return self.client.call_adyen_api( | |
| request, self.service, method, endpoint, idempotency_key, **kwargs | |
| ) |
| Delete a defense document | ||
| """ | ||
| endpoint = self.baseUrl + "/deleteDisputeDefenseDocument" | ||
| endpoint = self.baseUrl + f"/deleteDisputeDefenseDocument" |
There was a problem hiding this comment.
The f prefix on this string literal is redundant as there are no expressions to interpolate. This can be confusing for developers. For constructing URLs, it's more idiomatic to include the base URL variable within the f-string itself for better readability.
| endpoint = self.baseUrl + f"/deleteDisputeDefenseDocument" | |
| endpoint = f"{self.baseUrl}/deleteDisputeDefenseDocument" |
| return self.client.call_adyen_api( | ||
| request, self.service, method, endpoint, idempotency_key, **kwargs | ||
| ) | ||
| return self.client.call_adyen_api(request, self.service, method, endpoint, idempotency_key, **kwargs) |
There was a problem hiding this comment.
This line has become excessively long (over 100 characters), which harms readability and violates common Python style guidelines like PEP 8. The previous multi-line formatting was preferable. Please consider reformatting this call to span multiple lines.
| return self.client.call_adyen_api(request, self.service, method, endpoint, idempotency_key, **kwargs) | |
| return self.client.call_adyen_api( | |
| request, self.service, method, endpoint, idempotency_key, **kwargs | |
| ) |
| Get applicable defense reasons | ||
| """ | ||
| endpoint = self.baseUrl + "/retrieveApplicableDefenseReasons" | ||
| endpoint = self.baseUrl + f"/retrieveApplicableDefenseReasons" |
There was a problem hiding this comment.
The f prefix on this string literal is redundant as there are no expressions to interpolate. This can be confusing for developers. For constructing URLs, it's more idiomatic to include the base URL variable within the f-string itself for better readability.
| endpoint = self.baseUrl + f"/retrieveApplicableDefenseReasons" | |
| endpoint = f"{self.baseUrl}/retrieveApplicableDefenseReasons" |
| return self.client.call_adyen_api( | ||
| request, self.service, method, endpoint, idempotency_key, **kwargs | ||
| ) | ||
| return self.client.call_adyen_api(request, self.service, method, endpoint, idempotency_key, **kwargs) |
There was a problem hiding this comment.
This line has become excessively long (over 100 characters), which harms readability and violates common Python style guidelines like PEP 8. The previous multi-line formatting was preferable. Please consider reformatting this call to span multiple lines.
| return self.client.call_adyen_api(request, self.service, method, endpoint, idempotency_key, **kwargs) | |
| return self.client.call_adyen_api( | |
| request, self.service, method, endpoint, idempotency_key, **kwargs | |
| ) |
| Supply a defense document | ||
| """ | ||
| endpoint = self.baseUrl + "/supplyDefenseDocument" | ||
| endpoint = self.baseUrl + f"/supplyDefenseDocument" |
There was a problem hiding this comment.
The f prefix on this string literal is redundant as there are no expressions to interpolate. This can be confusing for developers. For constructing URLs, it's more idiomatic to include the base URL variable within the f-string itself for better readability.
| endpoint = self.baseUrl + f"/supplyDefenseDocument" | |
| endpoint = f"{self.baseUrl}/supplyDefenseDocument" |
| return self.client.call_adyen_api( | ||
| request, self.service, method, endpoint, idempotency_key, **kwargs | ||
| ) | ||
| return self.client.call_adyen_api(request, self.service, method, endpoint, idempotency_key, **kwargs) |
There was a problem hiding this comment.
This line has become excessively long (over 100 characters), which harms readability and violates common Python style guidelines like PEP 8. The previous multi-line formatting was preferable. Please consider reformatting this call to span multiple lines.
| return self.client.call_adyen_api(request, self.service, method, endpoint, idempotency_key, **kwargs) | |
| return self.client.call_adyen_api( | |
| request, self.service, method, endpoint, idempotency_key, **kwargs | |
| ) |
1 participant
This PR contains the automated changes for the
disputesservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.