[payment] Code generation: update services and models#453
[payment] Code generation: update services and models#453AdyenAutomationBot wants to merge 1 commit intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request contains automated updates to the payment service, specifically targeting the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request contains auto-generated changes to update payment services. The changes primarily involve switching to f-strings for URL construction and reformatting code. However, the f-strings are used on static string literals, which is redundant. I've provided suggestions to use f-strings idiomatically by enclosing the entire URL string. This will improve code clarity and is a good fix to apply to the code generator.
| Change the authorised amount | ||
| """ | ||
| endpoint = self.baseUrl + "/adjustAuthorisation" | ||
| endpoint = self.baseUrl + f"/adjustAuthorisation" |
There was a problem hiding this comment.
The use of an f-string on a string literal without any embedded expressions is unnecessary. For cleaner and more idiomatic code, the entire URL should be constructed within a single f-string.
| endpoint = self.baseUrl + f"/adjustAuthorisation" | |
| endpoint = f"{self.baseUrl}/adjustAuthorisation" |
| Cancel an authorisation | ||
| """ | ||
| endpoint = self.baseUrl + "/cancel" | ||
| endpoint = self.baseUrl + f"/cancel" |
There was a problem hiding this comment.
The use of an f-string on a string literal without any embedded expressions is unnecessary. For cleaner and more idiomatic code, the entire URL should be constructed within a single f-string.
| endpoint = self.baseUrl + f"/cancel" | |
| endpoint = f"{self.baseUrl}/cancel" |
| Cancel or refund a payment | ||
| """ | ||
| endpoint = self.baseUrl + "/cancelOrRefund" | ||
| endpoint = self.baseUrl + f"/cancelOrRefund" |
There was a problem hiding this comment.
The use of an f-string on a string literal without any embedded expressions is unnecessary. For cleaner and more idiomatic code, the entire URL should be constructed within a single f-string.
| endpoint = self.baseUrl + f"/cancelOrRefund" | |
| endpoint = f"{self.baseUrl}/cancelOrRefund" |
| Capture an authorisation | ||
| """ | ||
| endpoint = self.baseUrl + "/capture" | ||
| endpoint = self.baseUrl + f"/capture" |
There was a problem hiding this comment.
The use of an f-string on a string literal without any embedded expressions is unnecessary. For cleaner and more idiomatic code, the entire URL should be constructed within a single f-string.
| endpoint = self.baseUrl + f"/capture" | |
| endpoint = f"{self.baseUrl}/capture" |
| Deprecated | ||
| """ | ||
| endpoint = self.baseUrl + "/donate" | ||
| endpoint = self.baseUrl + f"/donate" |
There was a problem hiding this comment.
The use of an f-string on a string literal without any embedded expressions is unnecessary. For cleaner and more idiomatic code, the entire URL should be constructed within a single f-string.
| endpoint = self.baseUrl + f"/donate" | |
| endpoint = f"{self.baseUrl}/donate" |
| Create an authorisation | ||
| """ | ||
| endpoint = self.baseUrl + "/authorise" | ||
| endpoint = self.baseUrl + f"/authorise" |
There was a problem hiding this comment.
The use of an f-string on a string literal without any embedded expressions is unnecessary. For cleaner and more idiomatic code, the entire URL should be constructed within a single f-string.
| endpoint = self.baseUrl + f"/authorise" | |
| endpoint = f"{self.baseUrl}/authorise" |
| Complete a 3DS authorisation | ||
| """ | ||
| endpoint = self.baseUrl + "/authorise3d" | ||
| endpoint = self.baseUrl + f"/authorise3d" |
There was a problem hiding this comment.
The use of an f-string on a string literal without any embedded expressions is unnecessary. For cleaner and more idiomatic code, the entire URL should be constructed within a single f-string.
| endpoint = self.baseUrl + f"/authorise3d" | |
| endpoint = f"{self.baseUrl}/authorise3d" |
| Complete a 3DS2 authorisation | ||
| """ | ||
| endpoint = self.baseUrl + "/authorise3ds2" | ||
| endpoint = self.baseUrl + f"/authorise3ds2" |
There was a problem hiding this comment.
The use of an f-string on a string literal without any embedded expressions is unnecessary. For cleaner and more idiomatic code, the entire URL should be constructed within a single f-string.
| endpoint = self.baseUrl + f"/authorise3ds2" | |
| endpoint = f"{self.baseUrl}/authorise3ds2" |
| Get the 3DS authentication result | ||
| """ | ||
| endpoint = self.baseUrl + "/getAuthenticationResult" | ||
| endpoint = self.baseUrl + f"/getAuthenticationResult" |
There was a problem hiding this comment.
The use of an f-string on a string literal without any embedded expressions is unnecessary. For cleaner and more idiomatic code, the entire URL should be constructed within a single f-string.
| endpoint = self.baseUrl + f"/getAuthenticationResult" | |
| endpoint = f"{self.baseUrl}/getAuthenticationResult" |
| Get the 3DS2 authentication result | ||
| """ | ||
| endpoint = self.baseUrl + "/retrieve3ds2Result" | ||
| endpoint = self.baseUrl + f"/retrieve3ds2Result" |
There was a problem hiding this comment.
The use of an f-string on a string literal without any embedded expressions is unnecessary. For cleaner and more idiomatic code, the entire URL should be constructed within a single f-string.
| endpoint = self.baseUrl + f"/retrieve3ds2Result" | |
| endpoint = f"{self.baseUrl}/retrieve3ds2Result" |
1 participant
This PR contains the automated changes for the
paymentservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.