fix: install parity and spawn deserialization fallback#541
Merged
khaliqgant merged 8 commits intomainfrom Mar 11, 2026
Merged
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
khaliqgant
added a commit
that referenced
this pull request
Mar 11, 2026
Prevents agent.spawn_requested events handled by the JSON fallback from falling through to map_ws_event message processing. The normal deserialization path already had a continue at line 2591 but the fallback path was missing it. Addresses Devin review comment on #541. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
khaliqgant
added a commit
that referenced
this pull request
Mar 11, 2026
Match the pattern used by installDashboardBinary — run --version to verify the binary is functional, not just present on disk. Fixes stale or corrupt binaries being treated as "already installed". Addresses Devin review comment on #541. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
- Add installDashboardBinary() and installRelayAcpBinary() to postinstall so npm install downloads the same binaries as the curl installer - Add JSON fallback handler for agent.spawn_requested events that fail serde deserialization (e.g. task: null or missing fields), preventing silently dropped spawn requests - Add debug logging for spawn/release event processing Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Prevents agent.spawn_requested events handled by the JSON fallback from falling through to map_ws_event message processing. The normal deserialization path already had a continue at line 2591 but the fallback path was missing it. Addresses Devin review comment on #541. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Match the pattern used by installDashboardBinary — run --version to verify the binary is functional, not just present on disk. Fixes stale or corrupt binaries being treated as "already installed". Addresses Devin review comment on #541. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Aligns fallback JSON spawn path with primary path — dedup.insert_if_new is now always called regardless of whether the local echo dedup applies. Prevents theoretical edge case where re-delivered events with different JSON could bypass dedup.
The codegen script outputs to packages/config/src/cli-registry.generated.ts but CI was checking packages/sdk/src/models.generated.ts (which doesn't exist). Also check __init__.py in the diff step.
khaliqgant
force-pushed
the
fix/install-parity-and-spawn
branch
from
c6e689a to
c4ed694
Compare
khaliqgant
added a commit
that referenced
this pull request
Mar 25, 2026
* fix: install parity and spawn deserialization fallback - Add installDashboardBinary() and installRelayAcpBinary() to postinstall so npm install downloads the same binaries as the curl installer - Add JSON fallback handler for agent.spawn_requested events that fail serde deserialization (e.g. task: null or missing fields), preventing silently dropped spawn requests - Add debug logging for spawn/release event processing Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: add continue after JSON fallback spawn path Prevents agent.spawn_requested events handled by the JSON fallback from falling through to map_ws_event message processing. The normal deserialization path already had a continue at line 2591 but the fallback path was missing it. Addresses Devin review comment on #541. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: validate relay-acp binary before skipping reinstall Match the pattern used by installDashboardBinary — run --version to verify the binary is functional, not just present on disk. Fixes stale or corrupt binaries being treated as "already installed". Addresses Devin review comment on #541. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * update models * Update cli-registry.yaml * fix: always insert local spawn echo dedup key in fallback path Aligns fallback JSON spawn path with primary path — dedup.insert_if_new is now always called regardless of whether the local echo dedup applies. Prevents theoretical edge case where re-delivered events with different JSON could bypass dedup. * codegen * fix: codegen CI references wrong output file path The codegen script outputs to packages/config/src/cli-registry.generated.ts but CI was checking packages/sdk/src/models.generated.ts (which doesn't exist). Also check __init__.py in the diff step. --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
Screenshots