Use host header to build full URL for is request to itself check#896
Closed
Use host header to build full URL for is request to itself check#896
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
willem-delbare
approved these changes
Jan 27, 2026
| // Build full URL from Host header (e.g. for http.createServer / Next.js) | ||
| const host = context.headers.host; | ||
| if (typeof host === "string" && host.length > 0) { | ||
| return `http://${host}${context.url}`; |
Member
There was a problem hiding this comment.
It does not matter in this case because of the following code inside isRequestToItself, but maybe we should highlight that it does not determine the correct protocol?
// Special case for HTTP/HTTPS ports
// In production, the app will be served on port 80 and 443
if (baseURLPort === 80 && outboundPort === 443) {
return true;
}
if (baseURLPort === 443 && outboundPort === 80) {
return true;
}
Member
Author
|
Some problems with this PR, closing in favour of #796 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.