Update scanWorkspaceDocs any[] type to vscode.Uri[]#33
Merged
AlexJSully merged 2 commits intomainfrom Feb 15, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates type annotations in the workspace scanner to improve type safety by replacing any[] types with vscode.Uri[]. It also includes dependency updates for development packages and minor documentation clarifications.
Changes:
- Replaced
any[]return type withvscode.Uri[]inscanWorkspaceDocsfunction - Removed
as anytype assertions and replaced with explicitvscode.Uritypes in filter callbacks - Updated regex patterns for path splitting (stylistic change, functionally equivalent)
- Updated development dependencies to latest patch/minor versions
- Simplified documentation to remove unused configuration settings
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/scanner/workspaceScanner.ts | Changed return type from any[] to vscode.Uri[], removed type assertions, updated regex patterns |
| package.json | Updated devDependencies to latest versions (@types/node, @typescript-eslint/*, esbuild) |
| package-lock.json | Lockfile updates corresponding to package.json changes |
| docs/project/design-doc.md | Removed unused settings from example config, simplified scanner description |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.